github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make modifying log file perms best effort

Browse source 
qBittorrent is able to write to the log file, so it's ok if the permission change fails. The downside will be that the file remains readable to the world.
This commit is contained in:
Thomas Piccirello 2025-05-30 18:22:52 -07:00
commit ebc974a1ba
No known key found for this signature in database
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/app/filelogger.cpp
View file

@ -175,12 +175,14 @@ void FileLogger::flushLog()
void FileLogger::openLogFile()
{
if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text)
|| !m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner))
if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text))
{
m_logFile.close();
LogMsg(tr("An error occurred while trying to open the log file. Logging to file is disabled."), Log::CRITICAL);
return;
}
// best effort, don't report error
m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner);
}
void FileLogger::closeLogFile()