From ebc974a1ba1003c98c46d87b11bed2c2d5259571 Mon Sep 17 00:00:00 2001 From: Thomas Piccirello Date: Fri, 30 May 2025 18:22:52 -0700 Subject: [PATCH] Make modifying log file perms best effort qBittorrent is able to write to the log file, so it's ok if the permission change fails. The downside will be that the file remains readable to the world. --- src/app/filelogger.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/app/filelogger.cpp b/src/app/filelogger.cpp index 5436c1392..8bbe251d3 100644 --- a/src/app/filelogger.cpp +++ b/src/app/filelogger.cpp @@ -175,12 +175,14 @@ void FileLogger::flushLog() void FileLogger::openLogFile() { - if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text) - || !m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner)) + if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text)) { - m_logFile.close(); LogMsg(tr("An error occurred while trying to open the log file. Logging to file is disabled."), Log::CRITICAL); + return; } + + // best effort, don't report error + m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner); } void FileLogger::closeLogFile()