github/msft-calculator
1
0
Fork 0
mirror of https://github.com/Microsoft/calculator.git synced 2025-07-11 07:46:01 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Updating HistoryViewModel::SaveHistory so it (#819)

Browse source 
Taking a const ref of history items vector in HistoryViewModel::SaveHistory and iterating over those items using a range for loop.
This commit is contained in:
Scott Freeman 2019-12-01 12:02:34 -05:00 • committed by Matt Cooley
parent 369843dd37
commit d0785b2fad
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/CalcViewModel/HistoryViewModel.cpp
View file

@ -267,16 +267,16 @@ void HistoryViewModel::ClearHistory()
void HistoryViewModel::SaveHistory()
{
ApplicationDataContainer ^ historyContainer = GetHistoryContainer(m_currentMode);
auto currentHistoryVector = m_calculatorManager->GetHistoryItems(m_currentMode);
auto const& currentHistoryVector = m_calculatorManager->GetHistoryItems(m_currentMode);
bool failure = false;
int index = 0;
Platform::String ^ serializedHistoryItem;
for (auto iter = currentHistoryVector.begin(); iter != currentHistoryVector.end(); ++iter)
for (auto const& item : currentHistoryVector)
{
try
{
serializedHistoryItem = SerializeHistoryItem(*iter);
serializedHistoryItem = SerializeHistoryItem(item);
historyContainer->Values->Insert(index.ToString(), serializedHistoryItem);
}
catch (Platform::Exception ^)