From d0785b2fad14c0e58c87344f8d0f21f09f05ba65 Mon Sep 17 00:00:00 2001 From: Scott Freeman Date: Sun, 1 Dec 2019 12:02:34 -0500 Subject: [PATCH] Updating HistoryViewModel::SaveHistory so it (#819) Taking a const ref of history items vector in HistoryViewModel::SaveHistory and iterating over those items using a range for loop. --- src/CalcViewModel/HistoryViewModel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/CalcViewModel/HistoryViewModel.cpp b/src/CalcViewModel/HistoryViewModel.cpp index 20751032..58bd726d 100644 --- a/src/CalcViewModel/HistoryViewModel.cpp +++ b/src/CalcViewModel/HistoryViewModel.cpp @@ -267,16 +267,16 @@ void HistoryViewModel::ClearHistory() void HistoryViewModel::SaveHistory() { ApplicationDataContainer ^ historyContainer = GetHistoryContainer(m_currentMode); - auto currentHistoryVector = m_calculatorManager->GetHistoryItems(m_currentMode); + auto const& currentHistoryVector = m_calculatorManager->GetHistoryItems(m_currentMode); bool failure = false; int index = 0; Platform::String ^ serializedHistoryItem; - for (auto iter = currentHistoryVector.begin(); iter != currentHistoryVector.end(); ++iter) + for (auto const& item : currentHistoryVector) { try { - serializedHistoryItem = SerializeHistoryItem(*iter); + serializedHistoryItem = SerializeHistoryItem(item); historyContainer->Values->Insert(index.ToString(), serializedHistoryItem); } catch (Platform::Exception ^)