DrawableContainer extended to indicate if confirm/cancel is available. #397 (#399)

src/Greenshot.Base/Interfaces/Drawing/IDrawableContainer.cs

@@ -93,6 +93,11 @@ namespace Greenshot.Base.Interfaces.Drawing
         /// </summary>
         IList<IAdorner> Adorners { get; }
 
+        /// <summary>
+        /// Is confirm/cancel possible for this container
+        /// </summary>
+        bool IsConfirmable { get; }
+
         /// <summary>
         /// Adjust UI elements to the supplied DPI settings
         /// </summary>

src/Greenshot.Editor/Drawing/CropContainer.cs

@@ -264,9 +264,18 @@ namespace Greenshot.Editor.Drawing
             Invalidate();
             return true;
         }
-
+        /// <summary>
-        /// <inheritdoc cref="IDrawableContainer"/>
+        /// <inheritdoc />
+        /// <para/>
         /// Make sure this container is not undoable
+        /// </summary>
         public override bool IsUndoable => false;
+
+        /// <summary>
+        /// <inheritdoc />
+        /// <para/>
+        /// See dedicated confirm method <see cref="Surface.ConfirmCrop(bool)"/>
+        /// </summary>
+        public override bool IsConfirmable => true;
     }
 }

src/Greenshot.Editor/Drawing/DrawableContainer.cs

@@ -480,9 +480,12 @@ namespace Greenshot.Editor.Drawing
             g.DrawRectangle(pen, rect);
         }
 
-        /// <inheritdoc cref="IDrawableContainer"/>
+        /// <inheritdoc/>
         public virtual bool IsUndoable => true;
 
+        /// <inheritdoc/>
+        public virtual bool IsConfirmable => false;
+
         /// <summary>
         /// Make a following bounds change on this drawablecontainer undoable!
         /// </summary>

src/Greenshot.Editor/Drawing/Surface.cs

@@ -2108,7 +2108,7 @@ namespace Greenshot.Editor.Drawing
         {
             // create new collection so that we can iterate safely (selectedElements might change due with confirm/cancel)
             List<IDrawableContainer> selectedDCs = new List<IDrawableContainer>(selectedElements);
-            foreach (IDrawableContainer dc in selectedDCs)
+            foreach (IDrawableContainer dc in selectedDCs.Where(c => c.IsConfirmable))
             {                
                 throw new NotImplementedException($"No confirm/cancel defined for Container type {dc.GetType()}");               
             }