From 8aca1c82828b5a8df785423763cd8edcbde1c8f8 Mon Sep 17 00:00:00 2001
From: Christian Schulz <32000301+Christian-Schulz@users.noreply.github.com>
Date: Wed, 13 Apr 2022 09:53:46 +0200
Subject: [PATCH] DrawableContainer extended to indicate if confirm/cancel is
 available. #397 (#399)

---
 .../Interfaces/Drawing/IDrawableContainer.cs        |  5 +++++
 src/Greenshot.Editor/Drawing/CropContainer.cs       | 13 +++++++++++--
 src/Greenshot.Editor/Drawing/DrawableContainer.cs   |  5 ++++-
 src/Greenshot.Editor/Drawing/Surface.cs             |  2 +-
 4 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/src/Greenshot.Base/Interfaces/Drawing/IDrawableContainer.cs b/src/Greenshot.Base/Interfaces/Drawing/IDrawableContainer.cs
index 2363b7ac9..b42192916 100644
--- a/src/Greenshot.Base/Interfaces/Drawing/IDrawableContainer.cs
+++ b/src/Greenshot.Base/Interfaces/Drawing/IDrawableContainer.cs
@@ -93,6 +93,11 @@ namespace Greenshot.Base.Interfaces.Drawing
         /// </summary>
         IList<IAdorner> Adorners { get; }
 
+        /// <summary>
+        /// Is confirm/cancel possible for this container
+        /// </summary>
+        bool IsConfirmable { get; }
+
         /// <summary>
         /// Adjust UI elements to the supplied DPI settings
         /// </summary>
diff --git a/src/Greenshot.Editor/Drawing/CropContainer.cs b/src/Greenshot.Editor/Drawing/CropContainer.cs
index 936a1a2c8..f33045b61 100644
--- a/src/Greenshot.Editor/Drawing/CropContainer.cs
+++ b/src/Greenshot.Editor/Drawing/CropContainer.cs
@@ -264,9 +264,18 @@ namespace Greenshot.Editor.Drawing
             Invalidate();
             return true;
         }
-
-        /// <inheritdoc cref="IDrawableContainer"/>
+        /// <summary>
+        /// <inheritdoc />
+        /// <para/>
         /// Make sure this container is not undoable
+        /// </summary>
         public override bool IsUndoable => false;
+
+        /// <summary>
+        /// <inheritdoc />
+        /// <para/>
+        /// See dedicated confirm method <see cref="Surface.ConfirmCrop(bool)"/>
+        /// </summary>
+        public override bool IsConfirmable => true;
     }
 }
diff --git a/src/Greenshot.Editor/Drawing/DrawableContainer.cs b/src/Greenshot.Editor/Drawing/DrawableContainer.cs
index f8a14052b..7ae58bfe6 100644
--- a/src/Greenshot.Editor/Drawing/DrawableContainer.cs
+++ b/src/Greenshot.Editor/Drawing/DrawableContainer.cs
@@ -480,9 +480,12 @@ namespace Greenshot.Editor.Drawing
             g.DrawRectangle(pen, rect);
         }
 
-        /// <inheritdoc cref="IDrawableContainer"/>
+        /// <inheritdoc/>
         public virtual bool IsUndoable => true;
 
+        /// <inheritdoc/>
+        public virtual bool IsConfirmable => false;
+
         /// <summary>
         /// Make a following bounds change on this drawablecontainer undoable!
         /// </summary>
diff --git a/src/Greenshot.Editor/Drawing/Surface.cs b/src/Greenshot.Editor/Drawing/Surface.cs
index 8eb2a872e..ead40e74f 100644
--- a/src/Greenshot.Editor/Drawing/Surface.cs
+++ b/src/Greenshot.Editor/Drawing/Surface.cs
@@ -2108,7 +2108,7 @@ namespace Greenshot.Editor.Drawing
         {
             // create new collection so that we can iterate safely (selectedElements might change due with confirm/cancel)
             List<IDrawableContainer> selectedDCs = new List<IDrawableContainer>(selectedElements);
-            foreach (IDrawableContainer dc in selectedDCs)
+            foreach (IDrawableContainer dc in selectedDCs.Where(c => c.IsConfirmable))
             {                
                 throw new NotImplementedException($"No confirm/cancel defined for Container type {dc.GetType()}");               
             }