github/youtube-dl
1
0
Fork 0
mirror of https://github.com/ytdl-org/youtube-dl.git synced 2025-08-22 22:34:01 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

disable --mtime by default

Browse source 
the mtime of a file normally reflects the last modification time of the
file on disk rather than what the contents of the file represent.
youtube-dl goes against this convention by default, which can cause
issues when users don't know about youtube-dl special mtime behavior,
e.g.  premature deletion of files by cleanup scripts or time-based file
searches.

instead of behaving in this unconventional way by default, youtube-dl
should not modify the mtime of its output files unless the user
specifically asks for that.

fixes #1709
This commit is contained in:
flisk 2023-03-21 14:59:16 +01:00
commit 29ca6a33ed
2 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
README.md
View file

@ -263,8 +263,10 @@ Alternatively, refer to the [developer instructions](#developer-instructions) fo
files (restart from beginning)
--no-part Do not use .part files - write directly
into output file
--no-mtime Do not use the Last-modified header to
--mtime Use the Last-modified header to
set the file modification time
--no-mtime Do not use the Last-modified header to
set the file modification time (default)
--write-description Write video description to a
.description file
--write-info-json Write video metadata to a .info.json
@ -482,16 +484,13 @@ Alternatively, refer to the [developer instructions](#developer-instructions) fo
You can configure youtube-dl by placing any supported command line option to a configuration file. On Linux and macOS, the system wide configuration file is located at `/etc/youtube-dl.conf` and the user wide configuration file at `~/.config/youtube-dl/config`. On Windows, the user wide configuration file locations are `%APPDATA%\youtube-dl\config.txt` or `C:\Users\<user name>\youtube-dl.conf`. Note that by default configuration file may not exist so you may need to create it yourself.
For example, with the following configuration file youtube-dl will always extract the audio, not copy the mtime, use a proxy and save all videos under `Movies` directory in your home directory:
For example, with the following configuration file youtube-dl will always extract the audio, use a proxy and save all videos under `Movies` directory in your home directory:
```
# Lines starting with # are comments
# Always extract audio
-x
# Do not copy the mtime
--no-mtime
# Use this proxy
--proxy 127.0.0.1:3128

8
youtube_dl/options.py
View file

@ -733,10 +733,14 @@ def parseOpts(overrideArguments=None):
'--no-part',
action='store_true', dest='nopart', default=False,
help='Do not use .part files - write directly into output file')
filesystem.add_option(
'--mtime',
action='store_true', dest='updatetime', default=False,
help='Use the Last-modified header to set the file modification time')
filesystem.add_option(
'--no-mtime',
action='store_false', dest='updatetime', default=True,
help='Do not use the Last-modified header to set the file modification time')
action='store_false', dest='updatetime',
help='Do not use the Last-modified header to set the file modification time (default)')
filesystem.add_option(
'--write-description',
action='store_true', dest='writedescription', default=False,