Revert "[SECURITY] Fix OS command injection."

This commit is contained in:
Serghey Rodin 2015-12-11 21:14:49 +02:00
commit 39e9b6397b
115 changed files with 1980 additions and 1340 deletions

View file

@ -9,7 +9,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -19,18 +19,20 @@ if ($_SESSION['user'] != 'admin') {
}
if (!empty($_GET['user'])) {
$user = $_GET['user'];
$user=$_GET['user'];
}
if (!empty($_GET['job'])) {
$v_username = $user;
$v_job = $_GET['job'];
v_exec('v-unsuspend-cron-job', [$v_username, $v_job]);
$v_username = escapeshellarg($user);
$v_job = escapeshellarg($_GET['job']);
exec (VESTA_CMD."v-unsuspend-cron-job ".$v_username." ".$v_job, $output, $return_var);
}
check_return_code($return_var,$output);
unset($output);
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}

View file

@ -9,7 +9,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -19,18 +19,19 @@ if ($_SESSION['user'] != 'admin') {
}
if (!empty($_GET['user'])) {
$user = $_GET['user'];
$user=$_GET['user'];
}
if (!empty($_GET['database'])) {
$v_username = $user;
$v_database = $_GET['database'];
v_exec('v-unsuspend-database', [$v_username, $v_database]);
$v_username = escapeshellarg($user);
$v_database = escapeshellarg($_GET['database']);
exec (VESTA_CMD."v-unsuspend-database ".$v_username." ".$v_database, $output, $return_var);
check_return_code($return_var,$output);
unset($output);
}
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}

View file

@ -8,7 +8,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -23,12 +23,18 @@ if (!empty($_GET['user'])) {
// DNS domain
if ((!empty($_GET['domain'])) && (empty($_GET['record_id']))) {
$v_username = $user;
$v_domain = $_GET['domain'];
v_exec('v-unsuspend-dns-domain', [$v_username, $v_domain]);
$back = getenv('HTTP_REFERER');
$v_username = escapeshellarg($user);
$v_domain = escapeshellarg($_GET['domain']);
exec (VESTA_CMD."v-unsuspend-dns-domain ".$v_username." ".$v_domain, $output, $return_var);
if ($return_var != 0) {
$error = implode('<br>', $output);
if (empty($error)) $error = __('Error: vesta did not return any output.');
$_SESSION['error_msg'] = $error;
}
unset($output);
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}
header("Location: /list/dns/");
@ -37,22 +43,28 @@ if ((!empty($_GET['domain'])) && (empty($_GET['record_id']))) {
// DNS record
if ((!empty($_GET['domain'])) && (!empty($_GET['record_id']))) {
$v_username = $user;
$v_domain = $_GET['domain'];
$v_record_id = $_GET['record_id'];
v_exec('v-unsuspend-dns-record', [$v_username, $v_domain, $v_record_id]);
$back = getenv('HTTP_REFERER');
$v_username = escapeshellarg($user);
$v_domain = escapeshellarg($_GET['domain']);
$v_record_id = escapeshellarg($_GET['record_id']);
exec (VESTA_CMD."v-unsuspend-dns-record ".$v_username." ".$v_domain." ".$v_record_id, $output, $return_var);
if ($return_var != 0) {
$error = implode('<br>', $output);
if (empty($error)) $error = __('Error: vesta did not return any output.');
$_SESSION['error_msg'] = $error;
}
unset($output);
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}
header("Location: /list/dns/?domain=".$_GET['domain']);
exit;
}
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}

View file

@ -8,7 +8,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -18,13 +18,15 @@ if ($_SESSION['user'] != 'admin') {
}
if (!empty($_GET['rule'])) {
$v_rule = $_GET['rule'];
v_exec('v-unsuspend-firewall-rule', [$v_rule]);
$v_rule = escapeshellarg($_GET['rule']);
exec (VESTA_CMD."v-unsuspend-firewall-rule ".$v_rule, $output, $return_var);
}
check_return_code($return_var,$output);
unset($output);
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}

View file

@ -8,7 +8,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -23,12 +23,18 @@ if (!empty($_GET['user'])) {
// Mail domain
if ((!empty($_GET['domain'])) && (empty($_GET['account']))) {
$v_username = $user;
$v_domain = $_GET['domain'];
v_exec('v-unsuspend-mail-domain', [$v_username, $v_domain]);
$back = getenv('HTTP_REFERER');
$v_username = escapeshellarg($user);
$v_domain = escapeshellarg($_GET['domain']);
exec (VESTA_CMD."v-unsuspend-mail-domain ".$v_username." ".$v_domain, $output, $return_var);
if ($return_var != 0) {
$error = implode('<br>', $output);
if (empty($error)) $error = __('Error: vesta did not return any output.');
$_SESSION['error_msg'] = $error;
}
unset($output);
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}
header("Location: /list/mail/");
@ -37,22 +43,28 @@ if ((!empty($_GET['domain'])) && (empty($_GET['account']))) {
// Mail account
if ((!empty($_GET['domain'])) && (!empty($_GET['account']))) {
$v_username = $user;
$v_domain = $_GET['domain'];
$v_account = $_GET['account'];
v_exec('v-unsuspend-mail-account', [$v_username, $v_domain, $v_account]);
$back = getenv('HTTP_REFERER');
$v_username = escapeshellarg($user);
$v_domain = escapeshellarg($_GET['domain']);
$v_account = escapeshellarg($_GET['account']);
exec (VESTA_CMD."v-unsuspend-mail-account ".$v_username." ".$v_domain." ".$v_account, $output, $return_var);
if ($return_var != 0) {
$error = implode('<br>', $output);
if (empty($error)) $error = __('Error: vesta did not return any output.');
$_SESSION['error_msg'] = $error;
}
unset($output);
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}
header("Location: /list/mail/?domain=".$_GET['domain']);
exit;
}
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}

View file

@ -9,7 +9,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -19,13 +19,15 @@ if ($_SESSION['user'] != 'admin') {
}
if (!empty($_GET['user'])) {
$v_username = $_GET['user'];
v_exec('v-unsuspend-user', [$v_username]);
$v_username = escapeshellarg($_GET['user']);
exec (VESTA_CMD."v-unsuspend-user ".$v_username, $output, $return_var);
}
check_return_code($return_var,$output);
unset($output);
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}

View file

@ -8,7 +8,7 @@ include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
// Check token
if ((!isset($_GET['token'])) || ($_SESSION['token'] != $_GET['token'])) {
header('location: /login/');
exit;
exit();
}
// Check user
@ -17,18 +17,19 @@ if ($_SESSION['user'] != 'admin') {
exit;
}
if (!empty($_GET['user'])) {
$user = $_GET['user'];
$user=$_GET['user'];
}
if (!empty($_GET['domain'])) {
$v_username = $user;
$v_domain = $_GET['domain'];
v_exec('v-unsuspend-domain', [$v_username, $v_domain]);
$v_username = escapeshellarg($user);
$v_domain = escapeshellarg($_GET['domain']);
exec (VESTA_CMD."v-unsuspend-domain ".$v_username." ".$v_domain, $output, $return_var);
}
check_return_code($return_var,$output);
unset($output);
$back = getenv('HTTP_REFERER');
$back=getenv("HTTP_REFERER");
if (!empty($back)) {
header("Location: $back");
header("Location: ".$back);
exit;
}