Shellcheck (#23)

* Use ${var:?} to ensure this never expands to /* .
https://github.com/koalaman/shellcheck/wiki/SC2115

* Quote this to prevent word splitting
https://github.com/koalaman/shellcheck/wiki/SC2046
This commit is contained in:
Eric Nemchik 2018-03-13 10:48:14 -05:00 committed by Avi
commit 0a0c0c4bf5

View file

@ -101,7 +101,7 @@ unzip-strip() (
cp -r "$temp"/*/* "$dest" cp -r "$temp"/*/* "$dest"
else else
cp -r "$temp"/* "$dest" cp -r "$temp"/* "$dest"
fi && rm -rf "$temp"/* "$temp" fi && rm -rf "${temp:?}"/* "$temp"
) )
# Import any custom config to override the defaults, if necessary # Import any custom config to override the defaults, if necessary
@ -222,7 +222,7 @@ tempdir=$(mktemp -d)
file="$tempdir/ombi_$version.tar.gz" file="$tempdir/ombi_$version.tar.gz"
wget --quiet --show-progress -O $file "https://ci.appveyor.com/api/buildjobs/$jobId/artifacts/$filename" wget --quiet --show-progress -O $file "https://ci.appveyor.com/api/buildjobs/$jobId/artifacts/$filename"
.log 6 "Version $version downloaded...checking file size..." .log 6 "Version $version downloaded...checking file size..."
if [ $(wc -c < $file) != $size ]; then if [ "$(wc -c < $file)" != $size ]; then
.log 3 "Downloaded file size does not match expected file size...bailing!" .log 3 "Downloaded file size does not match expected file size...bailing!"
exit 2 exit 2
fi fi
@ -321,7 +321,7 @@ else
fi fi
.log 6 "Cleaning up..." .log 6 "Cleaning up..."
rm -rf "$tempdir"/* "$tempdir" rm -rf "${tempdir:?}"/* "$tempdir"
declare -i elapsedtime=$SECONDS declare -i elapsedtime=$SECONDS
declare -i minutes=0 declare -i minutes=0
declare -i seconds=0 declare -i seconds=0