From f4e0152d4ae1d79d19aeb07912c357d4e6475263 Mon Sep 17 00:00:00 2001
From: Roman Kelesidis <roman25052006.kelesh@gmail.com>
Date: Wed, 20 Dec 2023 09:00:02 +0700
Subject: [PATCH] Minor improvements (#1228)

---
 src/Legacy/Common/User.php | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/src/Legacy/Common/User.php b/src/Legacy/Common/User.php
index 2969484ed..902cefb2b 100644
--- a/src/Legacy/Common/User.php
+++ b/src/Legacy/Common/User.php
@@ -489,15 +489,6 @@ class User
             if ($c_sdata_curr !== $c_sdata_resv) {
                 bb_setcookie(COOKIE_DATA, $c_sdata_curr, httponly: true);
             }
-
-            // Unset sql debug cookies
-            if (!SQL_DEBUG || !APP_DEBUG) {
-                foreach (array('explain', 'sql_log', 'sql_log_full') as $cookie) {
-                    if (isset($_COOKIE[$cookie])) {
-                        bb_setcookie($cookie, null);
-                    }
-                }
-            }
         }
     }
 
@@ -510,7 +501,7 @@ class User
      *
      * @return bool|string
      */
-    public function verify_autologin_id($userdata, $expire_check = false, $create_new = true)
+    public function verify_autologin_id($userdata, bool $expire_check = false, bool $create_new = true): bool|string
     {
         global $bb_cfg;
 
@@ -534,14 +525,14 @@ class User
     /**
      * Create autologin_id
      *
-     * @param $userdata
+     * @param array $userdata
      * @param bool $create_new
      *
-     * @return bool|string
+     * @return string
      */
-    public function create_autologin_id($userdata, $create_new = true)
+    public function create_autologin_id(array $userdata, bool $create_new = true): string
     {
-        $autologin_id = ($create_new) ? make_rand_str(LOGIN_KEY_LENGTH) : '';
+        $autologin_id = $create_new ? make_rand_str(LOGIN_KEY_LENGTH) : '';
 
         DB()->query("
 			UPDATE " . BB_USERS . " SET