From f4bf7111bc325f3dd6399f8a876cfd3170eaba61 Mon Sep 17 00:00:00 2001
From: Roman Kelesidis <roman25052006.kelesh@gmail.com>
Date: Tue, 28 Mar 2023 17:55:22 +0700
Subject: [PATCH] Removed useless copy actions (#661)

---
 library/language/source/main.php       | 2 ++
 src/Dev.php                            | 4 +++-
 src/Legacy/SqlDb.php                   | 4 +++-
 styles/templates/default/viewforum.tpl | 2 +-
 styles/templates/default/viewtopic.tpl | 1 -
 5 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/library/language/source/main.php b/library/language/source/main.php
index b9384ff38..56dea8e1e 100644
--- a/library/language/source/main.php
+++ b/library/language/source/main.php
@@ -118,6 +118,8 @@ $lang['LOADING'] = 'Loading...';
 $lang['JUMPBOX_TITLE'] = 'Select forum';
 $lang['DISPLAYING_OPTIONS'] = 'Displaying options';
 
+$lang['COPY_TO_CLIPBOARD'] = 'Copy to clipboard';
+
 // Global Header strings
 $lang['REGISTERED_USERS'] = 'Registered Users:';
 $lang['BROWSING_FORUM'] = 'Users browsing this forum:';
diff --git a/src/Dev.php b/src/Dev.php
index 80ad6b2e4..422251b32 100644
--- a/src/Dev.php
+++ b/src/Dev.php
@@ -150,6 +150,8 @@ class Dev
      */
     private static function get_sql_log_html(object $db_obj, string $log_name): string
     {
+        global $lang;
+
         $log = '';
 
         foreach ($db_obj->dbg as $i => $dbg) {
@@ -162,7 +164,7 @@ class Dev
             $log .= ''
                 . '<div onmouseout="$(this).removeClass(\'sqlHover\');" onmouseover="$(this).addClass(\'sqlHover\');" onclick="$(this).toggleClass(\'sqlHighlight\');" class="sqlLogRow" title="' . $info . '">'
                 . '<span style="letter-spacing: -1px;">' . $time . ' </span>'
-                . '<span class="copyElement" data-clipboard-target="#' . $id . '" title="Copy to clipboard" style="color: gray; letter-spacing: -1px;">' . $perc . '</span>'
+                . '<span class="copyElement" data-clipboard-target="#' . $id . '" title="' . $lang['COPY_TO_CLIPBOARD'] . '" style="color: gray; letter-spacing: -1px;">' . $perc . '</span>'
                 . ' '
                 . '<span style="letter-spacing: 0;" id="' . $id . '">' . $sql . '</span>'
                 . '<span style="color: gray"> # ' . $info . ' </span>'
diff --git a/src/Legacy/SqlDb.php b/src/Legacy/SqlDb.php
index 35043a61a..0a983a922 100644
--- a/src/Legacy/SqlDb.php
+++ b/src/Legacy/SqlDb.php
@@ -957,6 +957,8 @@ class SqlDb
      */
     public function explain($mode, $html_table = '', $row = '')
     {
+        global $lang;
+
         $query = str_compact($this->cur_query);
         // remove comments
         $query = preg_replace('#(\s*)(/\*)(.*)(\*/)(\s*)#', '', $query);
@@ -998,7 +1000,7 @@ class SqlDb
 				<table width="98%" cellpadding="0" cellspacing="0" class="bodyline row2 bCenter" style="border-bottom: 0;">
 				<tr>
 					<th style="height: 22px; cursor: pointer;" align="left">&nbsp;' . $dbg['src'] . '&nbsp; [' . sprintf('%.4f', $dbg['time']) . ' s]&nbsp; <i>' . $dbg['info'] . '</i></th>
-					<th class="copyElement" data-clipboard-target="#' . $htid . '" style="height: 22px; cursor: pointer;" align="right" title="Copy to clipboard">' . "$this->db_server.$this->selected_db" . ' :: Query #' . ($this->num_queries + 1) . '&nbsp;</th>
+					<th class="copyElement" data-clipboard-target="#' . $htid . '" style="height: 22px; cursor: pointer;" align="right" title="' . $lang['COPY_TO_CLIPBOARD'] . '">' . "$this->db_server.$this->selected_db" . ' :: Query #' . ($this->num_queries + 1) . '&nbsp;</th>
 				</tr>
 				<tr><td colspan="2">' . $this->explain_hold . '</td></tr>
 				</table>
diff --git a/styles/templates/default/viewforum.tpl b/styles/templates/default/viewforum.tpl
index 0c68c6d1c..787140b36 100644
--- a/styles/templates/default/viewforum.tpl
+++ b/styles/templates/default/viewforum.tpl
@@ -267,7 +267,7 @@ td.topic_id { cursor: pointer; }
 <table width="100%">
 	<tr>
 		<td valign="bottom">
-			<h1 class="maintitle"><a href="{U_VIEW_FORUM}">{FORUM_NAME}</a>&nbsp;<a style="color: #800000;" data-clipboard-text="{FULL_URL}{U_VIEW_FORUM}" class="copyElement clickable" title="Copy to clipboard">&#8594;</a><!-- IF FORUM_DESC --><br><span style="font-size: 18px !important;">{FORUM_DESC}</span><!-- ENDIF --></h1>
+			<h1 class="maintitle"><a href="{U_VIEW_FORUM}">{FORUM_NAME}</a><!-- IF FORUM_DESC --><br><span style="font-size: 18px !important;">{FORUM_DESC}</span><!-- ENDIF --></h1>
 
 			<p class="small" id="moderators"><a style="text-decoration: none;" href="#">{L_MODERATORS}</a></p>
 			<script type="text/javascript">
diff --git a/styles/templates/default/viewtopic.tpl b/styles/templates/default/viewtopic.tpl
index 3bf3a1261..9383f834f 100644
--- a/styles/templates/default/viewtopic.tpl
+++ b/styles/templates/default/viewtopic.tpl
@@ -140,7 +140,6 @@ ajax.callback.post_mod_comment = function(data) {
 };
 </script>
 <a style="cursor: help; color: #800000;" title="{L_EDIT_TOPIC_TITLE}" onclick="edit_topic_title('edit'); return false" href="#">&para;</a>
-<a style="color: #800000;" data-clipboard-text="{FULL_URL}{U_VIEW_TOPIC}" class="copyElement clickable" title="Copy to clipboard">&#8594;</a>
 
 <div id="tt-edit-tpl" style="display: none;">
 	<div class="tt-edit" style="padding: 4px;">