From f48e7121dfd5feba4542d5b05d0aac0976ef6300 Mon Sep 17 00:00:00 2001
From: Roman Kelesidis <roman25052006.kelesh@gmail.com>
Date: Sat, 6 Jan 2024 12:59:26 +0700
Subject: [PATCH] Minor improvements (#1308)

* Minor improvements

* Updated
---
 admin/admin_forums.php                  | 6 +++++-
 library/ajax/change_user_rank.php       | 6 +++++-
 styles/templates/admin/admin_forums.tpl | 2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/admin/admin_forums.php b/admin/admin_forums.php
index 744216b17..4354a59e2 100644
--- a/admin/admin_forums.php
+++ b/admin/admin_forums.php
@@ -517,7 +517,11 @@ if ($mode) {
         case 'movedelcat':
             // Move or delete a category in the DB
             $from_id = (int)$_POST['from_id'];
-            $to_id = (int)$_POST['to_id'];
+            $to_id = (int)$_POST['to_id'] ?? -1;
+
+            if ($to_id === -1) {
+                bb_die($lang['NOWHERE_TO_MOVE']);
+            }
 
             if ($from_id == $to_id || !cat_exists($from_id) || !cat_exists($to_id)) {
                 bb_die('Bad input');
diff --git a/library/ajax/change_user_rank.php b/library/ajax/change_user_rank.php
index 80479ba1d..cde38f1a6 100644
--- a/library/ajax/change_user_rank.php
+++ b/library/ajax/change_user_rank.php
@@ -13,7 +13,11 @@ if (!defined('IN_AJAX')) {
 
 global $datastore, $lang;
 
-$ranks = $datastore->get('ranks');
+if (!$ranks = $datastore->get('ranks')) {
+    $datastore->update('ranks');
+    $ranks = $datastore->get('ranks');
+}
+
 $rank_id = (int)$this->request['rank_id'];
 
 if (!$user_id = (int)$this->request['user_id'] or !$profiledata = get_userdata($user_id)) {
diff --git a/styles/templates/admin/admin_forums.tpl b/styles/templates/admin/admin_forums.tpl
index 04c808728..3feba2b11 100644
--- a/styles/templates/admin/admin_forums.tpl
+++ b/styles/templates/admin/admin_forums.tpl
@@ -152,7 +152,7 @@ function toggle_cat_list (val)
 </tbody>
 <tr>
 	<td colspan="2" class="catBottom pad_4">
-		<input type="submit" name="submit" value="{S_SUBMIT_VALUE}" class="bold" />
+		<input type="submit" <!-- IF NOWHERE_TO_MOVE -->disabled<!-- ENDIF --> name="submit" value="{S_SUBMIT_VALUE}" class="bold" />
 	</td>
 </tr>
 </table>