Datastore improvements (#1538)

* Datastore improvements

* Updated

* Update functions.php

* Updated

* Updated

* Updated

* Update index.php

* Update index.php

* Update index.php

* Update index.php

* Update viewtopic.php

* Update functions.php

* Updated

* Updated

* Revert "Updated"

This reverts commit 0ff7d4ac60.

* Revert "Updated"

This reverts commit 8d637dff6c.

* Update index_data.php

* Update index_data.php

* Update index_data.php

* Updated

* Update CHANGELOG.md

CHANGELOG.md

@@ -10,6 +10,7 @@
 - Fixed broken "Disable Board" function [\#1529](https://github.com/torrentpier/torrentpier/pull/1529) ([belomaxorka](https://github.com/belomaxorka))
 - Fixed seed bonus accrual [\#1518](https://github.com/torrentpier/torrentpier/pull/1518) ([belomaxorka](https://github.com/belomaxorka))
 - [BETA] Added emojis support 😄😁 [\#1514](https://github.com/torrentpier/torrentpier/pull/1514) ([belomaxorka](https://github.com/belomaxorka))
+- Datastore improvements [\#1538](https://github.com/torrentpier/torrentpier/pull/1538) ([belomaxorka](https://github.com/belomaxorka))
 - Resize user/group avatar image if too large 🌆 [\#1512](https://github.com/torrentpier/torrentpier/pull/1512) ([belomaxorka](https://github.com/belomaxorka))
 - Increased PASSWORD_MAX_LENGTH [\#1510](https://github.com/torrentpier/torrentpier/pull/1510) ([belomaxorka](https://github.com/belomaxorka))
 - Some security improvements 🔑 [\#1503](https://github.com/torrentpier/torrentpier/pull/1503), [\#1505](https://github.com/torrentpier/torrentpier/pull/1505) ([belomaxorka](https://github.com/belomaxorka))

admin/admin_log.php

@@ -59,7 +59,7 @@ $def_forums = $all_forums;
 $def_sort = $sort_desc;
 
 // Moderators data
-if (!$mod = $datastore->get('moderators')) {
+if (!$mod = $datastore->get('moderators') and !$datastore->has('moderators')) {
     $datastore->update('moderators');
     $mod = $datastore->get('moderators');
 }
@@ -71,7 +71,7 @@ $users = array($lang['ACTS_LOG_ALL_ACTIONS'] => $all_users) + array_flip($mod['m
 unset($mod);
 
 // Forums data
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }

admin/admin_ug_auth.php

@@ -181,7 +181,7 @@ if ($mode == 'user' && (!empty($_POST['username']) || $user_id)) {
         bb_die($lang['NO_SUCH_USER']);
     }
 
-    if (!$forums = $datastore->get('cat_forums')) {
+    if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
         $datastore->update('cat_forums');
         $forums = $datastore->get('cat_forums');
     }
@@ -300,7 +300,7 @@ if ($mode == 'user' && (!empty($_POST['username']) || $user_id)) {
         bb_die($lang['GROUP_NOT_EXIST']);
     }
 
-    if (!$forums = $datastore->get('cat_forums')) {
+    if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
         $datastore->update('cat_forums');
         $forums = $datastore->get('cat_forums');
     }

admin/index.php

@@ -10,19 +10,19 @@
 require __DIR__ . '/pagestart.php';
 
 // Statistics
-if (!$stats = $datastore->get('stats')) {
+if (!$stats = $datastore->get('stats') and !$datastore->has('stats')) {
     $datastore->update('stats');
     $stats = $datastore->get('stats');
 }
 
 // Files integrity check
-if (!$files_integrity_data = $datastore->get('files_integrity')) {
+if (!$files_integrity_data = $datastore->get('files_integrity') and !$datastore->has('files_integrity')) {
     $datastore->update('files_integrity');
     $files_integrity_data = $datastore->get('files_integrity');
 }
 
 // Check for updates
-if (!$update_data = $datastore->get('check_updates')) {
+if (!$update_data = $datastore->get('check_updates') and !$datastore->has('check_updates')) {
     $datastore->update('check_updates');
     $update_data = $datastore->get('check_updates');
 }

index.php

@@ -65,13 +65,13 @@ $tracking_topics = get_tracks('topic');
 $tracking_forums = get_tracks('forum');
 
 // Statistics
-if (!$stats = $datastore->get('stats')) {
+if (!$stats = $datastore->get('stats') and !$datastore->has('stats')) {
     $datastore->update('stats');
     $stats = $datastore->get('stats');
 }
 
 // Forums data
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }
@@ -173,7 +173,7 @@ if (!$cat_forums = CACHE('bb_cache')->get($cache_name)) {
 
 // Obtain list of moderators
 $moderators = [];
-if (!$mod = $datastore->get('moderators')) {
+if (!$mod = $datastore->get('moderators') and !$datastore->has('moderators')) {
     $datastore->update('moderators');
     $mod = $datastore->get('moderators');
 }
@@ -321,7 +321,7 @@ if ($bb_cfg['bt_show_dl_stat_on_index'] && !IS_GUEST) {
 
 // Latest news
 if ($bb_cfg['show_latest_news']) {
-    if (!$latest_news = $datastore->get('latest_news')) {
+    if (!$latest_news = $datastore->get('latest_news') and !$datastore->has('latest_news')) {
         $datastore->update('latest_news');
         $latest_news = $datastore->get('latest_news');
     }
@@ -340,7 +340,7 @@ if ($bb_cfg['show_latest_news']) {
 
 // Network news
 if ($bb_cfg['show_network_news']) {
-    if (!$network_news = $datastore->get('network_news')) {
+    if (!$network_news = $datastore->get('network_news') and !$datastore->has('network_news')) {
         $datastore->update('network_news');
         $network_news = $datastore->get('network_news');
     }

library/ajax/change_user_rank.php

@@ -13,7 +13,7 @@ if (!defined('IN_AJAX')) {
 
 global $datastore, $lang;
 
-if (!$ranks = $datastore->get('ranks')) {
+if (!$ranks = $datastore->get('ranks') and !$datastore->has('ranks')) {
     $datastore->update('ranks');
     $ranks = $datastore->get('ranks');
 }

library/ajax/index_data.php

@@ -17,13 +17,19 @@ if (!$mode = (string)$this->request['mode']) {
     $this->ajax_die('invalid mode (empty)');
 }
 
+$datastore->enqueue([
+    'stats',
+    'moderators',
+    'cat_forums'
+]);
+
 $html = '';
 switch ($mode) {
     case 'birthday_week':
-        $stats = $datastore->get('stats');
+        if (!$stats = $datastore->get('stats') and !$datastore->has('stats')) {
-        $datastore->enqueue([
+            $datastore->update('stats');
-            'stats'
+            $stats = $datastore->get('stats');
-        ]);
+        }
 
         $users = [];
 
@@ -38,10 +44,10 @@ switch ($mode) {
         break;
 
     case 'birthday_today':
-        $stats = $datastore->get('stats');
+        if (!$stats = $datastore->get('stats') and !$datastore->has('stats')) {
-        $datastore->enqueue([
+            $datastore->update('stats');
-            'stats'
+            $stats = $datastore->get('stats');
-        ]);
+        }
 
         $users = [];
 
@@ -58,13 +64,12 @@ switch ($mode) {
     case 'get_forum_mods':
         $forum_id = (int)$this->request['forum_id'];
 
-        $datastore->enqueue([
+        if (!$mod = $datastore->get('moderators') and !$datastore->has('moderators')) {
-            'moderators',
+            $datastore->update('moderators');
-            'cat_forums'
+            $mod = $datastore->get('moderators');
-        ]);
+        }
 
         $moderators = [];
-        $mod = $datastore->get('moderators');
 
         if (isset($mod['mod_users'][$forum_id])) {
             foreach ($mod['mod_users'][$forum_id] as $user_id) {

library/includes/bbcode.php

@@ -116,7 +116,10 @@ function generate_smilies($mode)
         $user->session_start();
     }
 
-    $data = $datastore->get('smile_replacements');
+    if (!$data = $datastore->get('smile_replacements') and !$datastore->has('smile_replacements')) {
+        $datastore->update('smile_replacements');
+        $data = $datastore->get('smile_replacements');
+    }
 
     if ($sql = $data['smile']) {
         $num_smilies = 0;

library/includes/functions.php

@@ -296,7 +296,7 @@ function auth($type, $forum_id, $ug_data, array $f_access = [], $group_perm = UG
     // If f_access has been passed, or auth is needed to return an array of forums
     // then we need to pull the auth information on the given forum (or all forums)
     if (empty($f_access)) {
-        if (!$forums = $datastore->get('cat_forums')) {
+        if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
             $datastore->update('cat_forums');
             $forums = $datastore->get('cat_forums');
         }
@@ -997,7 +997,7 @@ function make_jumpbox(): void
         return;
     }
 
-    if (!$jumpbox = $datastore->get('jumpbox')) {
+    if (!$jumpbox = $datastore->get('jumpbox') and !$datastore->has('jumpbox')) {
         $datastore->update('jumpbox');
         $jumpbox = $datastore->get('jumpbox');
     }
@@ -1018,7 +1018,7 @@ function get_forum_select($mode = 'guest', $name = POST_FORUM_URL, $selected = n
         $max_length = HTML_SELECT_MAX_LENGTH;
     }
     $select = null === $all_forums_option ? [] : [$lang['ALL_AVAILABLE'] => $all_forums_option];
-    if (!$forums = $datastore->get('cat_forums')) {
+    if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
         $datastore->update('cat_forums');
         $forums = $datastore->get('cat_forums');
     }
@@ -1893,7 +1893,7 @@ function profile_url(array $data, bool $target_blank = false, bool $no_link = fa
 {
     global $bb_cfg, $lang, $datastore;
 
-    if (!$ranks = $datastore->get('ranks')) {
+    if (!$ranks = $datastore->get('ranks') and !$datastore->has('ranks')) {
         $datastore->update('ranks');
         $ranks = $datastore->get('ranks');
     }
@@ -2129,7 +2129,7 @@ function getBanInfo(int $userId = null): ?array
     global $datastore;
 
     // Get bans info from datastore
-    if (!$bans = $datastore->get('ban_list')) {
+    if (!$bans = $datastore->get('ban_list') and !$datastore->has('ban_list')) {
         $datastore->update('ban_list');
         $bans = $datastore->get('ban_list');
     }

library/includes/ucp/viewprofile.php

@@ -30,7 +30,7 @@ if (!$profiledata = get_userdata($_GET[POST_USERS_URL], profile_view: true)) {
     bb_die($lang['NO_USER_ID_SPECIFIED']);
 }
 
-if (!$ranks = $datastore->get('ranks')) {
+if (!$ranks = $datastore->get('ranks') and !$datastore->has('ranks')) {
     $datastore->update('ranks');
     $ranks = $datastore->get('ranks');
 }

search.php

@@ -104,7 +104,7 @@ $tracker_tbl = BB_BT_TRACKER . ' tr';
 $users_tbl = BB_USERS . ' u';
 
 // Cat/forum data
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }

src/Censor.php

@@ -41,15 +41,11 @@ class Censor
         }
 
         // Get censored words
-        if (!$censoredWords = $datastore->get('censor')) {
+        if (!$censoredWords = $datastore->get('censor') and !$datastore->has('censor')) {
             $datastore->update('censor');
             $censoredWords = $datastore->get('censor');
         }
 
-        if (isset($censoredWords['no_words'])) {
-            return;
-        }
-
         foreach ($censoredWords as $word) {
             $this->words[] = '#(?<![\p{Nd}\p{L}_])(' . str_replace('\*', '[\p{Nd}\p{L}_]*?', preg_quote($word['word'], '#')) . ')(?![\p{Nd}\p{L}_])#iu';
             $this->replacements[] = $word['replacement'];

src/Legacy/BBCode.php

@@ -350,7 +350,10 @@ class BBCode
         global $datastore;
 
         if (null === $this->smilies) {
-            $this->smilies = $datastore->get('smile_replacements');
+            if (!$this->smilies = $datastore->get('smile_replacements') and !$datastore->has('smile_replacements')) {
+                $datastore->update('smile_replacements');
+                $this->smilies = $datastore->get('smile_replacements');
+            }
         }
 
         if ($this->smilies) {

src/Legacy/Common/User.php

@@ -688,7 +688,7 @@ class User
             return '';
         }
 
-        if (!$forums = $datastore->get('cat_forums')) {
+        if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
             $datastore->update('cat_forums');
             $forums = $datastore->get('cat_forums');
         }
@@ -751,7 +751,7 @@ class User
         if (bf($this->opt, 'user_opt', 'user_porn_forums')) {
             global $datastore;
 
-            if (!$forums = $datastore->get('cat_forums')) {
+            if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
                 $datastore->update('cat_forums');
                 $forums = $datastore->get('cat_forums');
             }

src/Legacy/Datastore/Common.php

@@ -77,6 +77,15 @@ class Common
         return $this->data[$title];
     }
 
+    /**
+     * @param $title
+     * @return bool
+     */
+    public function has($title): bool
+    {
+        return isset($this->data[$title]);
+    }
+
     public function store($item_name, $item_data)
     {
     }

src/Sitemap.php

@@ -31,7 +31,7 @@ class Sitemap
 
         $forumUrls = [];
 
-        if (!$forums = $datastore->get('cat_forums')) {
+        if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
             $datastore->update('cat_forums');
             $forums = $datastore->get('cat_forums');
         }
@@ -61,7 +61,7 @@ class Sitemap
 
         $topicUrls = [];
 
-        if (!$forums = $datastore->get('cat_forums')) {
+        if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
             $datastore->update('cat_forums');
             $forums = $datastore->get('cat_forums');
         }

tracker.php

@@ -333,7 +333,7 @@ if ($search_id) {
 }
 
 // Get allowed for searching forums list
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }

viewforum.php

@@ -43,7 +43,7 @@ define('REQUESTED_PAGE', $req_page);
 caching_output(IS_GUEST, 'send', REQUESTED_PAGE . '_guest');
 
 set_die_append_msg();
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }
@@ -118,7 +118,7 @@ if ($mark_read && !IS_GUEST) {
 // Subforums
 $show_subforums = $bb_cfg['sf_on_first_page_only'] ? !$start : true;
 
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }

viewtopic.php

@@ -195,7 +195,7 @@ if ($is_auth['auth_mod']) {
 
 if ($moderation) {
     if (IS_ADMIN) {
-        if (!$forum_select = $datastore->get('viewtopic_forum_select')) {
+        if (!$forum_select = $datastore->get('viewtopic_forum_select') and !$datastore->has('viewtopic_forum_select')) {
             $datastore->update('viewtopic_forum_select');
             $forum_select = $datastore->get('viewtopic_forum_select');
         }
@@ -207,7 +207,7 @@ if ($moderation) {
     $template->assign_vars(['S_FORUM_SELECT' => $forum_select_html]);
 }
 
-if (!$forums = $datastore->get('cat_forums')) {
+if (!$forums = $datastore->get('cat_forums') and !$datastore->has('cat_forums')) {
     $datastore->update('cat_forums');
     $forums = $datastore->get('cat_forums');
 }
@@ -353,7 +353,7 @@ if ($postrow = DB()->fetch_rowset($sql)) {
     bb_die($lang['NO_POSTS_TOPIC']);
 }
 
-if (!$ranks = $datastore->get('ranks')) {
+if (!$ranks = $datastore->get('ranks') and !$datastore->has('ranks')) {
     $datastore->update('ranks');
     $ranks = $datastore->get('ranks');
 }