From 715faa2dd2369b7dddf62d192e82133cb54a9842 Mon Sep 17 00:00:00 2001 From: Roman Kelesidis Date: Tue, 19 Sep 2023 17:05:27 +0700 Subject: [PATCH] Removed useless chmod() (#907) --- admin/admin_attachments.php | 3 +-- library/includes/cron/jobs/attach_maintenance.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/admin/admin_attachments.php b/admin/admin_attachments.php index 166e63bd3..cd0aee645 100644 --- a/admin/admin_attachments.php +++ b/admin/admin_attachments.php @@ -347,10 +347,9 @@ if ($check_image_cat) { // Does the target directory exist, is it a directory and writeable if (!@file_exists(amod_realpath($upload_dir))) { - if (!bb_mkdir($upload_dir, 0755) && !is_dir($upload_dir)) { + if (!bb_mkdir($upload_dir) && !is_dir($upload_dir)) { throw new \RuntimeException(sprintf('Directory "%s" was not created', $upload_dir)); } - @chmod($upload_dir, 0777); if (!@file_exists(amod_realpath($upload_dir))) { $error = true; diff --git a/library/includes/cron/jobs/attach_maintenance.php b/library/includes/cron/jobs/attach_maintenance.php index 01504ea35..5a7edd6da 100644 --- a/library/includes/cron/jobs/attach_maintenance.php +++ b/library/includes/cron/jobs/attach_maintenance.php @@ -42,8 +42,7 @@ if ((int)$attach_config['img_create_thumbnail']) { $thumb_dir = "$attach_dir/" . THUMB_DIR; if (!is_dir($thumb_dir)) { - bb_mkdir($thumb_dir, 0755); - @chmod($thumb_dir, 0777); + bb_mkdir($thumb_dir); } }