diff --git a/upload/common.php b/upload/common.php index 0062edf4e..68ae49dc5 100644 --- a/upload/common.php +++ b/upload/common.php @@ -2086,9 +2086,17 @@ function log_request ($file = '', $prepend_str = false, $add_post = true) if ($prepend_str !== false) $str[] = $prepend_str; if (!empty($user->data)) $str[] = $user->id ."\t". html_entity_decode($user->name); $str[] = sprintf('%-15s', $_SERVER['REMOTE_ADDR']); - $str[] = @$_SERVER['REQUEST_URI']; - $str[] = @$_SERVER['HTTP_USER_AGENT']; - $str[] = @$_SERVER['HTTP_REFERER']; + + if (isset($_SERVER['REQUEST_URI'])) { + $str[] = $_SERVER['REQUEST_URI']; + } + if (isset($_SERVER['HTTP_USER_AGENT'])) { + $str[] = $_SERVER['HTTP_USER_AGENT']; + } + if (isset($_SERVER['HTTP_REFERER'])) { + $str[] = $_SERVER['HTTP_REFERER']; + } + if (!empty($_POST) && $add_post) $str[] = "post: ". str_compact(urldecode(http_build_query($_POST))); $str = join("\t", $str) . "\n"; bb_log($str, $file); diff --git a/upload/dl.php b/upload/dl.php index 29f72bd3f..52045d945 100644 --- a/upload/dl.php +++ b/upload/dl.php @@ -207,7 +207,7 @@ else { global $template; - $redirect_url = !empty($_POST['redirect_url']) ? $_POST['redirect_url'] : @$_SERVER['HTTP_REFERER']; + $redirect_url = isset($_POST['redirect_url']) ? $_POST['redirect_url'] : (isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '/' ); $message = '