From 4d0b2941e3ef6703ac2cd4c03524a93e688e0c39 Mon Sep 17 00:00:00 2001 From: Roman Kelesidis Date: Sun, 8 Jun 2025 22:44:50 +0300 Subject: [PATCH] feat(meta): Minor improvements to description generation (#1926) --- library/includes/page_header.php | 2 +- viewforum.php | 2 +- viewtopic.php | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/library/includes/page_header.php b/library/includes/page_header.php index f2f22581b..195bcec10 100644 --- a/library/includes/page_header.php +++ b/library/includes/page_header.php @@ -123,7 +123,7 @@ $template->assign_vars([ 'USE_TABLESORTER' => !empty($page_cfg['use_tablesorter']), 'ALLOW_ROBOTS' => !$bb_cfg['board_disable'] && (!isset($page_cfg['allow_robots']) || $page_cfg['allow_robots'] === true), - 'META_DESCRIPTION' => $page_cfg['meta_description'] ?? '', + 'META_DESCRIPTION' => !empty($page_cfg['meta_description']) ? trim(htmlCHR($page_cfg['meta_description'])) : '', 'SITENAME' => $bb_cfg['sitename'], 'U_INDEX' => BB_ROOT . 'index.php', diff --git a/viewforum.php b/viewforum.php index 7a1cdb4a3..d77d1ed99 100644 --- a/viewforum.php +++ b/viewforum.php @@ -53,7 +53,7 @@ if (!$forum_id or !$forum_data = @$forums['forum'][$forum_id]) { // Set meta description if (!empty($forum_data['forum_desc'])) { - $page_cfg['meta_description'] = htmlCHR($forum_data['forum_desc']); + $page_cfg['meta_description'] = $forum_data['forum_desc']; } // Make jumpbox diff --git a/viewtopic.php b/viewtopic.php index f952e0f15..82d39e685 100644 --- a/viewtopic.php +++ b/viewtopic.php @@ -673,7 +673,9 @@ for ($i = 0; $i < $total_posts; $i++) { // Set meta description if ($is_first_post || $i == 0) { - $page_cfg['meta_description'] = str_short(str_replace("\n", ' ', strip_tags(br2nl($message))), 220); + $message_meta = preg_replace('#\s*#si', ' ', $message); + $message_meta = str_replace(' ', '', $message_meta); + $page_cfg['meta_description'] = str_short(strip_tags($message_meta), 220); } $template->assign_block_vars('postrow', [