github/thc-hydra
1
0
Fork 0
mirror of https://github.com/vanhauser-thc/thc-hydra.git synced 2025-08-19 13:01:00 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Buffer overrun in hydra_report_debug.

Browse source
This commit is contained in:
veggie spam 2017-03-02 20:56:29 -05:00
commit 795e9c7baa
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
hydra-mod.c
View file

@ -695,21 +695,21 @@ void hydra_report_debug(FILE * st, char *format, ...) {
char bufOut[33000]; char bufOut[33000];
char temp[6]; char temp[6];
unsigned char cTemp; unsigned char cTemp;
int i = 0; int i = 0, len;
if (format == NULL) { if (format == NULL) {
fprintf(stderr, "[ERROR] no msg passed.\n"); fprintf(stderr, "[ERROR] no msg passed.\n");
} else { } else {
va_start(ap, format); va_start(ap, format);
memset(bufOut, 0, sizeof(bufOut)); memset(bufOut, 0, sizeof(bufOut));
memset(buf, 0, 512); memset(buf, 0, sizeof(buf));
vsnprintf(buf, sizeof(buf), format, ap); len = vsnprintf(buf, sizeof(buf), format, ap);
// Convert any chars less than 32d or greater than 126d to hex // Convert any chars less than 32d or greater than 126d to hex
for (i = 0; i < sizeof(buf); i++) { for (i = 0; i < len; i++) {
memset(temp, 0, 6); memset(temp, 0, 6);
cTemp = (unsigned char) buf[i]; cTemp = (unsigned char) buf[i];
if ((cTemp < 32 && cTemp > 0) || cTemp > 126) { if ((cTemp < 32 && cTemp >= 0) || cTemp > 126) {
sprintf(temp, "[%02X]", cTemp); sprintf(temp, "[%02X]", cTemp);
} else } else
sprintf(temp, "%c", cTemp); sprintf(temp, "%c", cTemp);