From 66bb7a6b6cf8984569df9f13eefc072c743960fc Mon Sep 17 00:00:00 2001 From: Darren Cocco Date: Wed, 11 May 2016 11:43:02 +1000 Subject: [PATCH] Fix http-post-form redirect mangled and segfaulted Off by one error found when processing Location: in redirects. Pointer handling mistake found when updating cookies after redirect. --- hydra-http-form.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hydra-http-form.c b/hydra-http-form.c index 9f0f91a..5ab2926 100644 --- a/hydra-http-form.c +++ b/hydra-http-form.c @@ -789,8 +789,8 @@ int start_http_form(int s, char *ip, int port, unsigned char options, char *misc if (strlen(str) - strlen(str2) == 0) { strcpy(str3, "/"); } else { - strncpy(str3, str + strlen(str2), strlen(str) - strlen(str2) - 1); - str3[strlen(str) - strlen(str2) - 1] = 0; + strncpy(str3, str + strlen(str2), strlen(str) - strlen(str2)); + str3[strlen(str) - strlen(str2)] = 0; } } else { strncpy(str2, webtarget, sizeof(str2)); @@ -859,7 +859,7 @@ int start_http_form(int s, char *ip, int port, unsigned char options, char *misc found = analyze_server_response(s); if (strlen(cookie) > 0) - process_cookies(ptr_cookie, cookie); + process_cookies(&ptr_cookie, cookie); } }