github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-08-22 06:13:54 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

bug checkPipePitfalls/xargs: Accept "--null" as alternate spelling of "-0"

Browse source 
When a shell script contains `find .. -print0 | xargs --null ..`, this
should not trigger the "use -print0" lint-warning, since -print0/--null
work together just as well as -print0/-0.
This commit is contained in:
Jonathan Paugh 2014-06-07 21:01:36 -04:00
commit f5cd37405b
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
ShellCheck/Analytics.hs
View file

@ -490,7 +490,7 @@ prop_checkPipePitfalls6 = verify checkPipePitfalls "find . | xargs foo"
checkPipePitfalls _ (T_Pipeline id _ commands) = do
for ["find", "xargs"] $
\(find:xargs:_) -> let args = deadSimple xargs in
unless (hasShortParameter args '0') $
unless (hasShortParameter args '0' || hasLongParameter args "--null") $
warn (getId find) 2038 "Use either 'find .. -print0 | xargs -0 ..' or 'find .. -exec .. +' to allow for non-alphanumeric filenames."
for ["?", "echo"] $
@ -523,6 +523,7 @@ checkPipePitfalls _ (T_Pipeline id _ commands) = do
first func (x:_) = func (getId x)
first _ _ = return ()
hasShortParameter list char = any (\x -> "-" `isPrefixOf` x && char `elem` x) list
hasLongParameter list string = elem string list
checkPipePitfalls _ _ = return ()
indexOfSublists sub = f 0