github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-08-22 14:23:53 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not warn when checking multiple exit values (fixes #1167)

Browse source
This commit is contained in:
Ng Zhi An 2018-05-06 15:08:20 -07:00
commit eb02dfd989
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/ShellCheck/Analytics.hs
View file

@ -2558,9 +2558,12 @@ prop_checkReturnAgainstZero6 = verifyNot checkReturnAgainstZero "[[ $R -eq 0 ]]"
prop_checkReturnAgainstZero7 = verify checkReturnAgainstZero "(( $? == 0 ))"
prop_checkReturnAgainstZero8 = verify checkReturnAgainstZero "(( $? ))"
prop_checkReturnAgainstZero9 = verify checkReturnAgainstZero "(( ! $? ))"
checkReturnAgainstZero _ token =
prop_checkReturnAgainstZero10 = verifyNot checkReturnAgainstZero "[[ $? -eq 0 || $? -eq 2 ]]"
prop_checkReturnAgainstZero11 = verify checkReturnAgainstZero "[[ 1 -eq 2 || $? -eq 0 ]]"
prop_checkReturnAgainstZero12 = verify checkReturnAgainstZero "[[ $? -eq 0 || 1 -eq 2 ]]"
checkReturnAgainstZero params token =
case token of
TC_Binary id _ _ lhs rhs -> check lhs rhs
TC_Binary id _ _ lhs rhs -> check_parent id lhs rhs
TA_Binary id _ lhs rhs -> check lhs rhs
TA_Unary id _ exp ->
when (isExitCode exp) $ message (getId exp)
@ -2568,6 +2571,13 @@ checkReturnAgainstZero _ token =
when (isExitCode exp) $ message (getId exp)
_ -> return ()
where
check_parent id lhs rhs =
case Map.lookup id (parentMap params) of
Just (TC_Or id _ _ (TC_Binary _ _ _ l1 r1) (TC_Binary _ _ _ l2 r2)) ->
-- if both braches are exit code checks
unless (any isExitCode [l1, r1] && any isExitCode [l2, r2]) $
check l1 r1 >> check l2 r2
_ -> check lhs rhs
check lhs rhs =
if isZero rhs && isExitCode lhs
then message (getId lhs)