github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-06 21:11:35 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add SC1133: Warn when a line starts with |/||/&& (fixes #1359)

Browse source
This commit is contained in:
Vidar Holen 2018-10-21 17:21:08 -07:00
parent b815242506
commit df0a0d41fa
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/ShellCheck/Parser.hs
View file

@ -1911,7 +1911,13 @@ readHereString = called "here string" $ do
word <- readNormalWord
return $ T_HereString id word
readNewlineList = many1 ((linefeed <|> carriageReturn) `thenSkip` spacing)
readNewlineList =
many1 ((linefeed <|> carriageReturn) `thenSkip` spacing) <* checkBadBreak
where
checkBadBreak = optional $ do
pos <- getPosition
try $ lookAhead (oneOf "|&") -- |, || or &&
parseProblemAt pos ErrorC 1133 "Unexpected start of line. If breaking lines, |/||/&& should be at the end of the previous one."
readLineBreak = optional readNewlineList
prop_readSeparator1 = isWarning readScript "a &; b"
@ -2300,7 +2306,7 @@ readSubshell = called "explicit subshell" $ do
allspacing
list <- readCompoundList
allspacing
char ')' <|> fail ") closing the subshell"
char ')' <|> fail "Expected ) closing the subshell"
id <- endSpan start
return $ T_Subshell id list