github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-12 08:06:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

SC2295 Warn about unquoted variables in PE patterns (fixes #2290)

Browse source
This commit is contained in:
Vidar Holen 2021-08-03 12:54:03 -07:00
parent 9b61506e0b
commit cf8066c07c
3 changed files with 33 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/ShellCheck/Analytics.hs
View file

@ -197,6 +197,7 @@ nodeChecks = [
,checkSecondArgIsComparison
,checkComparisonWithLeadingX
,checkCommandWithTrailingSymbol
,checkUnquotedParameterExpansionPattern
]
optionalChecks = map fst optionalTreeChecks
@ -388,7 +389,7 @@ replaceToken id params r =
repInsertionPoint = InsertBefore
}
surroundWidth id params s = fixWith [replaceStart id params 0 s, replaceEnd id params 0 s]
surroundWith id params s = fixWith [replaceStart id params 0 s, replaceEnd id params 0 s]
fixWith fixes = newFix { fixReplacements = fixes }
prop_checkEchoWc3 = verify checkEchoWc "n=$(echo $foo | wc -c)"
@ -1977,7 +1978,7 @@ quotesMayConflictWithSC2281 params t =
(getId t) == (getId me) && (parentId == getId cmd)
_ -> False
addDoubleQuotesAround params token = (surroundWidth (getId token) params "\"")
addDoubleQuotesAround params token = (surroundWith (getId token) params "\"")
checkSpacefulness'
:: (SpaceStatus -> Token -> String -> Writer [TokenComment] ()) ->
Parameters -> Token -> [TokenComment]
@ -3274,7 +3275,7 @@ checkArrayAssignmentIndices params root =
T_Literal id str <- parts
let (before, after) = break ('=' ==) str
guard $ all isDigit before && not (null after)
return $ warnWithFix id 2191 "The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it." (surroundWidth id params "\"")
return $ warnWithFix id 2191 "The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it." (surroundWith id params "\"")
in
if null literalEquals && isAssociative
then warn (getId t) 2190 "Elements in associative arrays need index, e.g. array=( [index]=value ) ."
@ -4405,5 +4406,31 @@ checkRequireDoubleBracket params =
_ -> False
prop_checkUnquotedParameterExpansionPattern1 = verify checkUnquotedParameterExpansionPattern "echo \"${var#$x}\""
prop_checkUnquotedParameterExpansionPattern2 = verify checkUnquotedParameterExpansionPattern "echo \"${var%%$(x)}\""
prop_checkUnquotedParameterExpansionPattern3 = verifyNot checkUnquotedParameterExpansionPattern "echo \"${var[#$x]}\""
prop_checkUnquotedParameterExpansionPattern4 = verifyNot checkUnquotedParameterExpansionPattern "echo \"${var%\"$x\"}\""
checkUnquotedParameterExpansionPattern params x =
case x of
T_DollarBraced _ True word@(T_NormalWord _ (T_Literal _ s : rest@(_:_))) -> do
let modifier = getBracedModifier $ concat $ oversimplify word
when ("%" `isPrefixOf` modifier || "#" `isPrefixOf` modifier) $
mapM_ check rest
_ -> return ()
where
check t =
case t of
T_DollarBraced {} -> inform t
T_DollarExpansion {} -> inform t
T_Backticked {} -> inform t
_ -> return ()
inform t =
infoWithFix (getId t) 2295
"Expansions inside ${..} need to be quoted separately, otherwise they match as patterns." $
surroundWith (getId t) params "\""
return []
runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])