github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-10 15:22:58 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Parse FD move operations like 2>&1- correctly. Fixes #1180.

Browse source
This commit is contained in:
Vidar Holen 2018-05-12 18:30:35 -07:00
parent aa3b3fdc56
commit cf608dc2f6
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/ShellCheck/Parser.hs
View file

@ -1716,8 +1716,15 @@ readIoFileOp = choice [g_DGREAT, g_LESSGREAT, g_GREATAND, g_LESSAND, g_CLOBBER,
readIoDuplicate = try $ do
id <- getNextId
op <- g_GREATAND <|> g_LESSAND
target <- readIoVariable <|> many1 digit <|> string "-"
target <- readIoVariable <|> digitsAndOrDash
return $ T_IoDuplicate id op target
where
-- either digits with optional dash, or a required dash
digitsAndOrDash = do
str <- many digit
dash <- (if null str then id else option "") $ string "-"
return $ str ++ dash
prop_readIoFile = isOk readIoFile ">> \"$(date +%YYmmDD)\""
readIoFile = called "redirection" $ do
@ -1744,6 +1751,7 @@ prop_readIoRedirect3 = isOk readIoRedirect "4>&-"
prop_readIoRedirect4 = isOk readIoRedirect "&> lol"
prop_readIoRedirect5 = isOk readIoRedirect "{foo}>&2"
prop_readIoRedirect6 = isOk readIoRedirect "{foo}<&-"
prop_readIoRedirect7 = isOk readIoRedirect "{foo}>&1-"
readIoRedirect = do
id <- getNextId
n <- readIoSource