github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-08-24 07:05:43 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix issue #1733 (False negative in SC2155)

Browse source
This commit is contained in:
Tito Sacchi 2019-10-28 17:40:56 +01:00
commit be0d0247b1
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/ShellCheck/Analytics.hs
View file

@ -2788,11 +2788,12 @@ prop_checkMaskedReturns2 = verify checkMaskedReturns "declare a=$(false)"
prop_checkMaskedReturns3 = verify checkMaskedReturns "declare a=\"`false`\"" prop_checkMaskedReturns3 = verify checkMaskedReturns "declare a=\"`false`\""
prop_checkMaskedReturns4 = verifyNot checkMaskedReturns "declare a; a=$(false)" prop_checkMaskedReturns4 = verifyNot checkMaskedReturns "declare a; a=$(false)"
prop_checkMaskedReturns5 = verifyNot checkMaskedReturns "f() { local -r a=$(false); }" prop_checkMaskedReturns5 = verifyNot checkMaskedReturns "f() { local -r a=$(false); }"
checkMaskedReturns _ t@(T_SimpleCommand id _ (cmd:rest)) = potentially $ do checkMaskedReturns _ t@(T_SimpleCommand id preopts (cmd:rest)) = potentially $ do
name <- getCommandName t name <- getCommandName t
guard $ name `elem` ["declare", "export"] guard $ name `elem` ["declare", "export"]
|| name == "local" && "r" `notElem` map snd (getAllFlags t) || name == "local" && "r" `notElem` map snd (getAllFlags t)
return $ mapM_ checkArgs rest || not (null preopts)
return $ mapM_ checkArgs (preopts ++ rest)
where where
checkArgs (T_Assignment id _ _ _ word) | any hasReturn $ getWordParts word = checkArgs (T_Assignment id _ _ _ word) | any hasReturn $ getWordParts word =
warn id 2155 "Declare and assign separately to avoid masking return values." warn id 2155 "Declare and assign separately to avoid masking return values."