github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-07 05:21:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2117 from brother/patch-1

Browse source 
Change error 2076 to a warning.
This commit is contained in:
Vidar Holen 2021-03-07 20:47:53 -08:00 • committed by GitHub
commit a69d6cb661
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ShellCheck/Analytics.hs
View file

@ -1216,8 +1216,8 @@ checkQuotedCondRegex _ (TC_Binary _ _ "=~" _ rhs) =
where where
error t = error t =
unless (isConstantNonRe t) $ unless (isConstantNonRe t) $
err (getId t) 2076 warn (getId t) 2076
"Don't quote right-hand side of =~, it'll match literally rather than as a regex." "Remove quotes from right-hand side of =~ to match as a regex rather than literally."
re = mkRegex "[][*.+()|]" re = mkRegex "[][*.+()|]"
hasMetachars s = s `matches` re hasMetachars s = s `matches` re
isConstantNonRe t = fromMaybe False $ do isConstantNonRe t = fromMaybe False $ do