github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-16 10:03:08 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improved bad indirection detection

Browse source
This commit is contained in:
Vidar Holen 2013-07-05 09:15:08 -07:00
parent 73c6202842
commit a20a3499ed
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
ShellCheck/Analytics.hs
View file

@ -1096,16 +1096,26 @@ checkBackticks _ = return ()
prop_checkIndirectExpansion1 = verify checkIndirectExpansion "${foo$n}"
prop_checkIndirectExpansion2 = verifyNot checkIndirectExpansion "${foo//$n/lol}"
checkIndirectExpansion (T_DollarBraced id (T_NormalWord _ ((T_Literal _ s):attempt:_))) =
case attempt of T_DollarExpansion _ _ -> doit
T_Backticked _ _ -> doit
T_DollarBraced _ _ -> doit
T_DollarArithmetic _ _ -> doit
_ -> return ()
prop_checkIndirectExpansion3 = verify checkIndirectExpansion "${$#}"
prop_checkIndirectExpansion4 = verify checkIndirectExpansion "${var${n}_$((i%2))}"
prop_checkIndirectExpansion5 = verifyNot checkIndirectExpansion "${bar}"
checkIndirectExpansion (T_DollarBraced i (T_NormalWord _ contents)) =
when (isIndirection contents) $
err i "To expand via indirection, use name=\"foo$n\"; echo \"${!name}\"."
where
doit = if all isVariableChar s
then err id "To expand via indirection, use name=\"foo$n\"; echo \"${!name}\""
else return ()
isIndirection vars =
let list = catMaybes (map isIndirectionPart vars) in
not (null list) && all id list
isIndirectionPart t =
case t of T_DollarExpansion _ _ -> Just True
T_Backticked _ _ -> Just True
T_DollarBraced _ _ -> Just True
T_DollarArithmetic _ _ -> Just True
T_Literal _ s -> if all isVariableChar s
then Nothing
else Just False
_ -> Just False
checkIndirectExpansion _ = return ()
prop_checkInexplicablyUnquoted1 = verify checkInexplicablyUnquoted "echo 'var='value';'"