github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-12 16:13:19 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't mention arrays in SC2089 in sh/dash (fixes #1014)

Browse source
This commit is contained in:
Vidar Holen 2019-04-27 16:22:01 -07:00
parent bf1003eae3
commit 9470b9dc31
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ShellCheck/Analytics.hs
View file

@ -1822,12 +1822,16 @@ checkQuotesInLiterals params t =
&& not (isQuoteFree parents expr)
&& not (squashesQuotes expr)
then [
makeComment WarningC (fromJust assignment) 2089
"Quotes/backslashes will be treated literally. Use an array.",
makeComment WarningC (fromJust assignment) 2089 $
"Quotes/backslashes will be treated literally. " ++ suggestion,
makeComment WarningC (getId expr) 2090
"Quotes/backslashes in this variable will not be respected."
]
else [])
suggestion =
if supportsArrays (shellType params)
then "Use an array."
else "Rewrite using set/\"$@\" or functions."
prop_checkFunctionsUsedExternally1 =