github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-12 08:06:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Suppress SC2216 when piping to cp/mv/rm -i (fixes #3141).

Browse source
This commit is contained in:
Vidar Holen 2025-04-06 19:26:54 -07:00
parent d3001f337a
commit 8ff0c5be7a
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ShellCheck/Analytics.hs
View file

@ -3596,6 +3596,8 @@ prop_checkPipeToNowhere17 = verify checkPipeToNowhere "echo World | cat << 'EOF'
prop_checkPipeToNowhere18 = verifyNot checkPipeToNowhere "ls 1>&3 3>&1 3>&- | wc -l"
prop_checkPipeToNowhere19 = verifyNot checkPipeToNowhere "find . -print0 | du --files0-from=/dev/stdin"
prop_checkPipeToNowhere20 = verifyNot checkPipeToNowhere "find . | du --exclude-from=/dev/fd/0"
prop_checkPipeToNowhere21 = verifyNot checkPipeToNowhere "yes | cp -ri foo/* bar"
prop_checkPipeToNowhere22 = verifyNot checkPipeToNowhere "yes | rm --interactive *"
data PipeType = StdoutPipe | StdoutStderrPipe | NoPipe deriving (Eq)
checkPipeToNowhere :: Parameters -> Token -> WriterT [TokenComment] Identity ()
@ -3661,6 +3663,7 @@ checkPipeToNowhere params t =
commandSpecificException name cmd =
case name of
"du" -> any ((`elem` ["exclude-from", "files0-from"]) . snd) $ getAllFlags cmd
_ | name `elem` interactiveFlagCmds -> hasInteractiveFlag cmd
_ -> False
warnAboutDupes (n, list@(_:_:_)) =
@ -3684,7 +3687,7 @@ checkPipeToNowhere params t =
name <- getCommandBasename cmd
guard $ name `elem` nonReadingCommands
guard . not $ hasAdditionalConsumers cmd
guard . not $ name `elem` ["cp", "mv", "rm"] && cmd `hasFlag` "i"
guard . not $ name `elem` interactiveFlagCmds && hasInteractiveFlag cmd
let suggestion =
if name == "echo"
then "Did you want 'cat' instead?"
@ -3699,6 +3702,9 @@ checkPipeToNowhere params t =
treeContains pred t = isNothing $
doAnalysis (guard . not . pred) t
interactiveFlagCmds = [ "cp", "mv", "rm" ]
hasInteractiveFlag cmd = cmd `hasFlag` "i" || cmd `hasFlag` "interactive"
mayConsume t =
case t of
T_ProcSub _ "<" _ -> True