github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-08-22 14:23:53 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix off-by-one in overlap check for fixes

Browse source 
Previously if we have 2 ranges like:
start: 6, end: 6
start: 6, end: 6
they would not be considered as overlap

Fixes #1431
This commit is contained in:
Ng Zhi An 2018-12-29 16:36:24 +08:00
commit 71751f3144
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ShellCheck/Fixer.hs
View file

@ -10,7 +10,7 @@ class Ranged a where
end :: a -> Position
overlap :: a -> a -> Bool
overlap x y =
(yStart >= xStart && yStart < xEnd) || (yStart < xStart && yEnd > xStart)
(yStart >= xStart && yStart <= xEnd) || (yStart < xStart && yEnd > xStart)
where
yStart = start y
yEnd = end y