diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs index c65645d..c3d676a 100644 --- a/src/ShellCheck/Analytics.hs +++ b/src/ShellCheck/Analytics.hs @@ -3029,11 +3029,9 @@ checkArrayAssignmentIndices params root = T_NormalWord _ parts -> let literalEquals = do - part <- parts - (id, str) <- case part of - T_Literal id str -> [(id,str)] - _ -> [] - guard $ '=' `elem` str && hasNumericIndex str + T_Literal id str <- parts + let (before, after) = break ('=' ==) str + guard $ all isDigit before && not (null after) return $ warnWithFix id 2191 "The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it." (surroundWidth id params "\"") in if null literalEquals && isAssociative @@ -3041,8 +3039,6 @@ checkArrayAssignmentIndices params root = else sequence_ literalEquals _ -> return () - where - hasNumericIndex str = all isDigit $ takeWhile (/= '=') str prop_checkUnmatchableCases1 = verify checkUnmatchableCases "case foo in bar) true; esac"