github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-05 20:41:35 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use the result of the comparison directly instead of an if/else

Browse source
This commit is contained in:
Joseph C. Sible 2024-12-13 23:20:48 -05:00
parent 0ecaf2b5f1
commit 5adfea21ee
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ShellCheck/Analytics.hs
View file

@ -5082,9 +5082,7 @@ checkExpansionWithRedirection params t =
T_FdRedirect id "1" (T_IoDuplicate _ _ _) -> return () T_FdRedirect id "1" (T_IoDuplicate _ _ _) -> return ()
T_FdRedirect id "" (T_IoDuplicate _ op _) | op `elem` [T_GREATAND (Id 0), T_Greater (Id 0)] -> emit id captureId True T_FdRedirect id "" (T_IoDuplicate _ op _) | op `elem` [T_GREATAND (Id 0), T_Greater (Id 0)] -> emit id captureId True
T_FdRedirect id str (T_IoFile _ op file) | str `elem` ["", "1"] && op `elem` [ T_DGREAT (Id 0), T_Greater (Id 0) ] -> T_FdRedirect id str (T_IoFile _ op file) | str `elem` ["", "1"] && op `elem` [ T_DGREAT (Id 0), T_Greater (Id 0) ] ->
if getLiteralString file == Just "/dev/null" emit id captureId $ getLiteralString file /= Just "/dev/null"
then emit id captureId False
else emit id captureId True
_ -> acc _ -> acc
emit redirectId captureId suggestTee = do emit redirectId captureId suggestTee = do