github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-07-07 05:21:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't warn about repeated range in [[ -v arr[xxx] ]] (fixes #2285)

Browse source
This commit is contained in:
Vidar Holen 2021-07-25 12:59:56 -07:00
parent 9eb63c97e6
commit 0d58337cdd
3 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/ShellCheck/Analytics.hs
View file

@ -2519,8 +2519,10 @@ prop_checkCharRangeGlob3 = verify checkCharRangeGlob "ls [10-15]"
prop_checkCharRangeGlob4 = verifyNot checkCharRangeGlob "ls [a-zA-Z]"
prop_checkCharRangeGlob5 = verifyNot checkCharRangeGlob "tr -d [a-zA-Z]" -- tr has 2060
prop_checkCharRangeGlob6 = verifyNot checkCharRangeGlob "[[ $x == [!!]* ]]"
prop_checkCharRangeGlob7 = verifyNot checkCharRangeGlob "[[ -v arr[keykey] ]]"
prop_checkCharRangeGlob8 = verifyNot checkCharRangeGlob "[[ arr[keykey] -gt 1 ]]"
checkCharRangeGlob p t@(T_Glob id str) |
isCharClass str && not (isParamTo (parentMap p) "tr" t) =
isCharClass str && not (isParamTo (parentMap p) "tr" t) && not (isDereferenced t) =
if ":" `isPrefixOf` contents
&& ":" `isSuffixOf` contents
&& contents /= ":"
@ -2537,6 +2539,15 @@ checkCharRangeGlob p t@(T_Glob id str) |
'!':rest -> rest
'^':rest -> rest
x -> x
-- Check if this is a dereferencing context like [[ -v array[operandhere] ]]
isDereferenced = fromMaybe False . msum . map isDereferencingOp . getPath (parentMap p)
isDereferencingOp t =
case t of
TC_Binary _ DoubleBracket str _ _ -> return $ isDereferencingBinaryOp str
TC_Unary _ _ str _ -> return $ str == "-v"
T_SimpleCommand {} -> return False
_ -> Nothing
checkCharRangeGlob _ _ = return ()