github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck synced 2025-08-20 13:23:55 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge ab9dfe4ee3 into ed081f8f43

Browse source
This commit is contained in:
Ben Blank 2025-07-27 20:32:10 -07:00 • committed by GitHub
commit 09f1ecc336
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ShellCheck/Analytics.hs
View file

@ -3119,7 +3119,7 @@ checkShouldUseGrepQ params t =
T_DollarExpansion _ [x] -> getPipeline x
T_Pipeline _ _ cmds -> return cmds
_ -> fail "unknown"
isGrep = (`elem` ["grep", "egrep", "fgrep", "zgrep"])
isGrep = (`elem` ["grep", "egrep", "fgrep", "rgrep", "zgrep"])
prop_checkTestArgumentSplitting1 = verify checkTestArgumentSplitting "[ -e *.mp3 ]"
prop_checkTestArgumentSplitting2 = verifyNot checkTestArgumentSplitting "[[ $a == *b* ]]"

5
src/ShellCheck/Checks/Commands.hs
View file

@ -93,6 +93,7 @@ commandChecks = [
,checkDeprecatedTempfile
,checkDeprecatedEgrep
,checkDeprecatedFgrep
,checkDeprecatedRgrep
,checkWhileGetoptsCase
,checkCatastrophicRm
,checkLetUsage
@ -992,6 +993,10 @@ prop_checkDeprecatedFgrep = verify checkDeprecatedFgrep "fgrep '*' files"
checkDeprecatedFgrep = CommandCheck (Basename "fgrep") $
\t -> info (getId $ getCommandTokenOrThis t) 2197 "fgrep is non-standard and deprecated. Use grep -F instead."
prop_checkDeprecatedRgrep = verify checkDeprecatedRgrep "rgrep '*' dir"
checkDeprecatedRgrep = CommandCheck (Basename "rgrep") $
\t -> info (getId $ getCommandTokenOrThis t) 2324 "rgrep is non-standard and deprecated. Use grep -r instead."
prop_checkWhileGetoptsCase1 = verify checkWhileGetoptsCase "while getopts 'a:b' x; do case $x in a) foo;; esac; done"
prop_checkWhileGetoptsCase2 = verify checkWhileGetoptsCase "while getopts 'a:' x; do case $x in a) foo;; b) bar;; esac; done"
prop_checkWhileGetoptsCase3 = verifyNot checkWhileGetoptsCase "while getopts 'a:b' x; do case $x in a) foo;; b) bar;; *) :;esac; done"