From fb0818eec46bd958945765f8b57311d748ec8cf6 Mon Sep 17 00:00:00 2001 From: Dmitry Vilkov Date: Fri, 10 Jan 2025 23:39:55 +0400 Subject: [PATCH] Fix typo in WebApplication::isAuthNeeded() If we want local auth without username/password (m_isLocalAuthEnabled is set) and client address is loopback, we should return false from WebApplication::isAuthNeeded(). --- src/webui/webapplication.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/webui/webapplication.cpp b/src/webui/webapplication.cpp index 168fd16c2..751111168 100644 --- a/src/webui/webapplication.cpp +++ b/src/webui/webapplication.cpp @@ -700,7 +700,7 @@ QString WebApplication::generateSid() const bool WebApplication::isAuthNeeded() { - if (!m_isLocalAuthEnabled && m_clientAddress.isLoopback()) + if (m_isLocalAuthEnabled && m_clientAddress.isLoopback()) return false; if (m_isAuthSubnetWhitelistEnabled && Utils::Net::isIPInSubnets(m_clientAddress, m_authSubnetWhitelist)) return false;