From f58d6ae98474bee8aa8dd3360324e810f707d1b1 Mon Sep 17 00:00:00 2001 From: skomerko <168652295+skomerko@users.noreply.github.com> Date: Thu, 13 Feb 2025 20:50:00 +0100 Subject: [PATCH] WebUI: Make context menu target selectors more precise --- src/webui/www/private/rename_files.html | 2 +- src/webui/www/private/scripts/prop-files.js | 2 +- src/webui/www/private/scripts/search.js | 2 +- src/webui/www/private/views/log.html | 2 +- src/webui/www/private/views/rss.html | 4 ++-- src/webui/www/private/views/searchplugins.html | 2 +- src/webui/www/private/views/transferlist.html | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/webui/www/private/rename_files.html b/src/webui/www/private/rename_files.html index 27310e0de..f8eefa009 100644 --- a/src/webui/www/private/rename_files.html +++ b/src/webui/www/private/rename_files.html @@ -21,7 +21,7 @@ } = window.MUI.Windows.instances["multiRenamePage"]; const bulkRenameFilesContextMenu = new window.qBittorrent.ContextMenu.ContextMenu({ - targets: "#bulkRenameFilesTableDiv tr", + targets: "#bulkRenameFilesTableDiv tbody tr", menu: "multiRenameFilesMenu", actions: { ToggleSelection: (element, ref) => { diff --git a/src/webui/www/private/scripts/prop-files.js b/src/webui/www/private/scripts/prop-files.js index 69875fa92..39c9db083 100644 --- a/src/webui/www/private/scripts/prop-files.js +++ b/src/webui/www/private/scripts/prop-files.js @@ -575,7 +575,7 @@ window.qBittorrent.PropFiles ??= (() => { }; const torrentFilesContextMenu = new window.qBittorrent.ContextMenu.ContextMenu({ - targets: "#torrentFilesTableDiv tr", + targets: "#torrentFilesTableDiv tbody tr", menu: "torrentFilesMenu", actions: { Rename: (element, ref) => { diff --git a/src/webui/www/private/scripts/search.js b/src/webui/www/private/scripts/search.js index cd97bde5d..d2a2d2899 100644 --- a/src/webui/www/private/scripts/search.js +++ b/src/webui/www/private/scripts/search.js @@ -109,7 +109,7 @@ window.qBittorrent.Search ??= (() => { // load "Search in" preference from local storage $("searchInTorrentName").value = (LocalPreferences.get("search_in_filter") === "names") ? "names" : "everywhere"; const searchResultsTableContextMenu = new window.qBittorrent.ContextMenu.ContextMenu({ - targets: "#searchResultsTableDiv tr", + targets: "#searchResultsTableDiv tbody tr", menu: "searchResultsTableMenu", actions: { Download: downloadSearchTorrent, diff --git a/src/webui/www/private/views/log.html b/src/webui/www/private/views/log.html index a988e5ba5..0790bc0bb 100644 --- a/src/webui/www/private/views/log.html +++ b/src/webui/www/private/views/log.html @@ -206,7 +206,7 @@ }); const logTableContextMenu = new window.qBittorrent.ContextMenu.ContextMenu({ - targets: ":is(#logMessageView, #logPeerView) tr", + targets: ":is(#logMessageTableDiv, #logPeerTableDiv) tbody tr", menu: "logTableMenu", actions: { Clear: () => { diff --git a/src/webui/www/private/views/rss.html b/src/webui/www/private/views/rss.html index e1aa96bf0..31d0b2561 100644 --- a/src/webui/www/private/views/rss.html +++ b/src/webui/www/private/views/rss.html @@ -218,7 +218,7 @@ $("rssFetchingDisabled").classList.remove("invisible"); const rssFeedContextMenu = new window.qBittorrent.ContextMenu.RssFeedContextMenu({ - targets: "#rssFeedTableDiv tr", + targets: "#rssFeedTableDiv tbody tr", menu: "rssFeedMenu", actions: { update: (el) => { @@ -288,7 +288,7 @@ rssFeedTable.setup("rssFeedTableDiv", "rssFeedFixedHeaderDiv", rssFeedContextMenu); const rssArticleContextMenu = new window.qBittorrent.ContextMenu.RssArticleContextMenu({ - targets: "#rssArticleTableDiv tr", + targets: "#rssArticleTableDiv tbody tr", menu: "rssArticleMenu", actions: { Download: (el) => { diff --git a/src/webui/www/private/views/searchplugins.html b/src/webui/www/private/views/searchplugins.html index e6a6b5bea..768b605fc 100644 --- a/src/webui/www/private/views/searchplugins.html +++ b/src/webui/www/private/views/searchplugins.html @@ -94,7 +94,7 @@ const setup = () => { searchPluginsTable = new window.qBittorrent.DynamicTable.SearchPluginsTable(); searchPluginsTableContextMenu = new window.qBittorrent.ContextMenu.SearchPluginsTableContextMenu({ - targets: "#searchPluginsTableDiv tr", + targets: "#searchPluginsTableDiv tbody tr", menu: "searchPluginsTableMenu", actions: { Enabled: enablePlugin, diff --git a/src/webui/www/private/views/transferlist.html b/src/webui/www/private/views/transferlist.html index 40dfdac7a..0692a06db 100644 --- a/src/webui/www/private/views/transferlist.html +++ b/src/webui/www/private/views/transferlist.html @@ -29,7 +29,7 @@ // create a context menu const contextMenu = new window.qBittorrent.ContextMenu.TorrentsTableContextMenu({ - targets: "#torrentsTableDiv tr", + targets: "#torrentsTableDiv tbody tr", menu: "torrentsTableMenu", actions: { start: (element, ref) => {