github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-19 12:59:56 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

WebUI: use correct property for selecting child elements

Browse source 
`firstChild` will select the first `Node` which is often not intended (it should be
`Element` instead).
This commit is contained in:
Chocobo1 2024-11-20 22:38:32 +08:00
commit f34787e6ba
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
5 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/webui/www/private/scripts/client.js
View file

@ -339,28 +339,28 @@ window.addEventListener("DOMContentLoaded", () => {
// Show Top Toolbar is enabled by default // Show Top Toolbar is enabled by default
let showTopToolbar = LocalPreferences.get("show_top_toolbar", "true") === "true"; let showTopToolbar = LocalPreferences.get("show_top_toolbar", "true") === "true";
if (!showTopToolbar) { if (!showTopToolbar) {
$("showTopToolbarLink").firstChild.style.opacity = "0"; $("showTopToolbarLink").firstElementChild.style.opacity = "0";
$("mochaToolbar").addClass("invisible"); $("mochaToolbar").addClass("invisible");
} }
// Show Status Bar is enabled by default // Show Status Bar is enabled by default
let showStatusBar = LocalPreferences.get("show_status_bar", "true") === "true"; let showStatusBar = LocalPreferences.get("show_status_bar", "true") === "true";
if (!showStatusBar) { if (!showStatusBar) {
$("showStatusBarLink").firstChild.style.opacity = "0"; $("showStatusBarLink").firstElementChild.style.opacity = "0";
$("desktopFooterWrapper").addClass("invisible"); $("desktopFooterWrapper").addClass("invisible");
} }
// Show Filters Sidebar is enabled by default // Show Filters Sidebar is enabled by default
let showFiltersSidebar = LocalPreferences.get("show_filters_sidebar", "true") === "true"; let showFiltersSidebar = LocalPreferences.get("show_filters_sidebar", "true") === "true";
if (!showFiltersSidebar) { if (!showFiltersSidebar) {
$("showFiltersSidebarLink").firstChild.style.opacity = "0"; $("showFiltersSidebarLink").firstElementChild.style.opacity = "0";
$("filtersColumn").addClass("invisible"); $("filtersColumn").addClass("invisible");
$("filtersColumn_handle").addClass("invisible"); $("filtersColumn_handle").addClass("invisible");
} }
let speedInTitle = LocalPreferences.get("speed_in_browser_title_bar") === "true"; let speedInTitle = LocalPreferences.get("speed_in_browser_title_bar") === "true";
if (!speedInTitle) if (!speedInTitle)
$("speedInBrowserTitleBarLink").firstChild.style.opacity = "0"; $("speedInBrowserTitleBarLink").firstElementChild.style.opacity = "0";
// After showing/hiding the toolbar + status bar // After showing/hiding the toolbar + status bar
window.qBittorrent.Client.showSearchEngine(LocalPreferences.get("show_search_engine") !== "false"); window.qBittorrent.Client.showSearchEngine(LocalPreferences.get("show_search_engine") !== "false");
@ -465,7 +465,7 @@ window.addEventListener("DOMContentLoaded", () => {
if (filterEl.classList.toggle("invisible", hideFilter)) if (filterEl.classList.toggle("invisible", hideFilter))
return; return;
} }
filterEl.firstElementChild.lastChild.nodeValue = filterTitle.replace("%1", filterTorrentCount); filterEl.firstElementChild.lastChild.textContent = filterTitle.replace("%1", filterTorrentCount);
}; };
const updateFiltersList = () => { const updateFiltersList = () => {
@ -1122,11 +1122,11 @@ window.addEventListener("DOMContentLoaded", () => {
showTopToolbar = !showTopToolbar; showTopToolbar = !showTopToolbar;
LocalPreferences.set("show_top_toolbar", showTopToolbar.toString()); LocalPreferences.set("show_top_toolbar", showTopToolbar.toString());
if (showTopToolbar) { if (showTopToolbar) {
$("showTopToolbarLink").firstChild.style.opacity = "1"; $("showTopToolbarLink").firstElementChild.style.opacity = "1";
$("mochaToolbar").removeClass("invisible"); $("mochaToolbar").removeClass("invisible");
} }
else { else {
$("showTopToolbarLink").firstChild.style.opacity = "0"; $("showTopToolbarLink").firstElementChild.style.opacity = "0";
$("mochaToolbar").addClass("invisible"); $("mochaToolbar").addClass("invisible");
} }
MochaUI.Desktop.setDesktopSize(); MochaUI.Desktop.setDesktopSize();
@ -1136,11 +1136,11 @@ window.addEventListener("DOMContentLoaded", () => {
showStatusBar = !showStatusBar; showStatusBar = !showStatusBar;
LocalPreferences.set("show_status_bar", showStatusBar.toString()); LocalPreferences.set("show_status_bar", showStatusBar.toString());
if (showStatusBar) { if (showStatusBar) {
$("showStatusBarLink").firstChild.style.opacity = "1"; $("showStatusBarLink").firstElementChild.style.opacity = "1";
$("desktopFooterWrapper").removeClass("invisible"); $("desktopFooterWrapper").removeClass("invisible");
} }
else { else {
$("showStatusBarLink").firstChild.style.opacity = "0"; $("showStatusBarLink").firstElementChild.style.opacity = "0";
$("desktopFooterWrapper").addClass("invisible"); $("desktopFooterWrapper").addClass("invisible");
} }
MochaUI.Desktop.setDesktopSize(); MochaUI.Desktop.setDesktopSize();
@ -1174,12 +1174,12 @@ window.addEventListener("DOMContentLoaded", () => {
showFiltersSidebar = !showFiltersSidebar; showFiltersSidebar = !showFiltersSidebar;
LocalPreferences.set("show_filters_sidebar", showFiltersSidebar.toString()); LocalPreferences.set("show_filters_sidebar", showFiltersSidebar.toString());
if (showFiltersSidebar) { if (showFiltersSidebar) {
$("showFiltersSidebarLink").firstChild.style.opacity = "1"; $("showFiltersSidebarLink").firstElementChild.style.opacity = "1";
$("filtersColumn").removeClass("invisible"); $("filtersColumn").removeClass("invisible");
$("filtersColumn_handle").removeClass("invisible"); $("filtersColumn_handle").removeClass("invisible");
} }
else { else {
$("showFiltersSidebarLink").firstChild.style.opacity = "0"; $("showFiltersSidebarLink").firstElementChild.style.opacity = "0";
$("filtersColumn").addClass("invisible"); $("filtersColumn").addClass("invisible");
$("filtersColumn_handle").addClass("invisible"); $("filtersColumn_handle").addClass("invisible");
} }
@ -1190,9 +1190,9 @@ window.addEventListener("DOMContentLoaded", () => {
speedInTitle = !speedInTitle; speedInTitle = !speedInTitle;
LocalPreferences.set("speed_in_browser_title_bar", speedInTitle.toString()); LocalPreferences.set("speed_in_browser_title_bar", speedInTitle.toString());
if (speedInTitle) if (speedInTitle)
$("speedInBrowserTitleBarLink").firstChild.style.opacity = "1"; $("speedInBrowserTitleBarLink").firstElementChild.style.opacity = "1";
else else
$("speedInBrowserTitleBarLink").firstChild.style.opacity = "0"; $("speedInBrowserTitleBarLink").firstElementChild.style.opacity = "0";
processServerState(); processServerState();
}); });
@ -1216,42 +1216,42 @@ window.addEventListener("DOMContentLoaded", () => {
const updateTabDisplay = () => { const updateTabDisplay = () => {
if (window.qBittorrent.Client.isShowRssReader()) { if (window.qBittorrent.Client.isShowRssReader()) {
$("showRssReaderLink").firstChild.style.opacity = "1"; $("showRssReaderLink").firstElementChild.style.opacity = "1";
$("mainWindowTabs").removeClass("invisible"); $("mainWindowTabs").removeClass("invisible");
$("rssTabLink").removeClass("invisible"); $("rssTabLink").removeClass("invisible");
if (!MochaUI.Panels.instances.RssPanel) if (!MochaUI.Panels.instances.RssPanel)
addRssPanel(); addRssPanel();
} }
else { else {
$("showRssReaderLink").firstChild.style.opacity = "0"; $("showRssReaderLink").firstElementChild.style.opacity = "0";
$("rssTabLink").addClass("invisible"); $("rssTabLink").addClass("invisible");
if ($("rssTabLink").hasClass("selected")) if ($("rssTabLink").hasClass("selected"))
$("transfersTabLink").click(); $("transfersTabLink").click();
} }
if (window.qBittorrent.Client.isShowSearchEngine()) { if (window.qBittorrent.Client.isShowSearchEngine()) {
$("showSearchEngineLink").firstChild.style.opacity = "1"; $("showSearchEngineLink").firstElementChild.style.opacity = "1";
$("mainWindowTabs").removeClass("invisible"); $("mainWindowTabs").removeClass("invisible");
$("searchTabLink").removeClass("invisible"); $("searchTabLink").removeClass("invisible");
if (!MochaUI.Panels.instances.SearchPanel) if (!MochaUI.Panels.instances.SearchPanel)
addSearchPanel(); addSearchPanel();
} }
else { else {
$("showSearchEngineLink").firstChild.style.opacity = "0"; $("showSearchEngineLink").firstElementChild.style.opacity = "0";
$("searchTabLink").addClass("invisible"); $("searchTabLink").addClass("invisible");
if ($("searchTabLink").hasClass("selected")) if ($("searchTabLink").hasClass("selected"))
$("transfersTabLink").click(); $("transfersTabLink").click();
} }
if (window.qBittorrent.Client.isShowLogViewer()) { if (window.qBittorrent.Client.isShowLogViewer()) {
$("showLogViewerLink").firstChild.style.opacity = "1"; $("showLogViewerLink").firstElementChild.style.opacity = "1";
$("mainWindowTabs").removeClass("invisible"); $("mainWindowTabs").removeClass("invisible");
$("logTabLink").removeClass("invisible"); $("logTabLink").removeClass("invisible");
if (!MochaUI.Panels.instances.LogPanel) if (!MochaUI.Panels.instances.LogPanel)
addLogPanel(); addLogPanel();
} }
else { else {
$("showLogViewerLink").firstChild.style.opacity = "0"; $("showLogViewerLink").firstElementChild.style.opacity = "0";
$("logTabLink").addClass("invisible"); $("logTabLink").addClass("invisible");
if ($("logTabLink").hasClass("selected")) if ($("logTabLink").hasClass("selected"))
$("transfersTabLink").click(); $("transfersTabLink").click();

4
src/webui/www/private/scripts/contextmenu.js
View file

@ -246,13 +246,13 @@ window.qBittorrent.ContextMenu ??= (() => {
} }
setItemChecked(item, checked) { setItemChecked(item, checked) {
this.menu.getElement("a[href$=" + item + "]").firstChild.style.opacity = this.menu.getElement("a[href$=" + item + "]").firstElementChild.style.opacity =
checked ? "1" : "0"; checked ? "1" : "0";
return this; return this;
} }
getItemChecked(item) { getItemChecked(item) {
return this.menu.getElement("a[href$=" + item + "]").firstChild.style.opacity !== "0"; return this.menu.getElement("a[href$=" + item + "]").firstElementChild.style.opacity !== "0";
} }
// hide an item // hide an item

6
src/webui/www/private/scripts/dynamicTable.js
View file

@ -492,9 +492,9 @@ window.qBittorrent.DynamicTable ??= (() => {
const autoResizeAllElement = createResizeElement("Resize All", "#autoResizeAllAction"); const autoResizeAllElement = createResizeElement("Resize All", "#autoResizeAllAction");
const autoResizeElement = createResizeElement("Resize", "#autoResizeAction"); const autoResizeElement = createResizeElement("Resize", "#autoResizeAction");
ul.firstChild.classList.add("separator"); ul.firstElementChild.classList.add("separator");
ul.insertBefore(autoResizeAllElement, ul.firstChild); ul.insertBefore(autoResizeAllElement, ul.firstElementChild);
ul.insertBefore(autoResizeElement, ul.firstChild); ul.insertBefore(autoResizeElement, ul.firstElementChild);
ul.inject(document.body); ul.inject(document.body);
this.headerContextMenu = new DynamicTableHeaderContextMenuClass({ this.headerContextMenu = new DynamicTableHeaderContextMenuClass({

2
src/webui/www/private/scripts/prop-trackers.js
View file

@ -132,7 +132,7 @@ window.qBittorrent.PropTrackers ??= (() => {
}, },
EditTracker: (element, ref) => { EditTracker: (element, ref) => {
// only allow editing of one row // only allow editing of one row
element.firstChild.click(); element.firstElementChild.click();
editTrackerFN(element); editTrackerFN(element);
}, },
RemoveTracker: (element, ref) => { RemoveTracker: (element, ref) => {

2
src/webui/www/private/scripts/prop-webseeds.js
View file

@ -103,7 +103,7 @@ window.qBittorrent.PropWebseeds ??= (() => {
}, },
EditWebSeed: (element, ref) => { EditWebSeed: (element, ref) => {
// only allow editing of one row // only allow editing of one row
element.firstChild.click(); element.firstElementChild.click();
editWebSeedFN(element); editWebSeedFN(element);
}, },
RemoveWebSeed: (element, ref) => { RemoveWebSeed: (element, ref) => {