WebUI: always provide event variable

This is unifying coding style and avoid wrong usages.

PR #22676.

src/webui/www/private/addpeers.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Escape":

src/webui/www/private/addtrackers.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Escape":

src/webui/www/private/addwebseeds.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Escape":

src/webui/www/private/confirmfeeddeletion.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             document.getElementById("cancelBtn").focus();
             document.getElementById("cancelBtn").addEventListener("click", (e) => {
                 e.preventDefault();

src/webui/www/private/confirmruleclear.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             document.getElementById("cancelBtn").focus();
             document.getElementById("cancelBtn").addEventListener("click", (e) => {
                 e.preventDefault();

src/webui/www/private/confirmruledeletion.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             document.getElementById("cancelBtn").focus();
             document.getElementById("cancelBtn").addEventListener("click", (e) => {
                 e.preventDefault();

src/webui/www/private/confirmtrackerdeletion.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             const searchParams = new URLSearchParams(window.location.search);
             const host = searchParams.get("host");
 

src/webui/www/private/download.html

@@ -172,7 +172,7 @@
 
         let submitted = false;
 
-        document.getElementById("downloadForm").addEventListener("submit", () => {
+        document.getElementById("downloadForm").addEventListener("submit", (event) => {
             document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
 
             document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
@@ -182,7 +182,7 @@
             submitted = true;
         });
 
-        document.getElementById("download_frame").addEventListener("load", () => {
+        document.getElementById("download_frame").addEventListener("load", (event) => {
             if (submitted)
                 window.parent.qBittorrent.Client.closeFrameWindow(window);
         });

src/webui/www/private/editfeedurl.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/edittracker.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/editwebseed.html

@@ -12,7 +12,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/newcategory.html

@@ -14,7 +14,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/newfeed.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/newfolder.html

@@ -14,7 +14,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/newrule.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/newtag.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/rename.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/rename_feed.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/rename_file.html

@@ -14,7 +14,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/rename_rule.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/scripts/client.js

@@ -174,7 +174,7 @@ let selectedStatus = LocalPreferences.get("selected_filter", "all");
 let setStatusFilter = () => {};
 let toggleFilterDisplay = () => {};
 
-window.addEventListener("DOMContentLoaded", () => {
+window.addEventListener("DOMContentLoaded", (event) => {
     let isSearchPanelLoaded = false;
     let isLogPanelLoaded = false;
     let isRssPanelLoaded = false;
@@ -1095,7 +1095,7 @@ window.addEventListener("DOMContentLoaded", () => {
         }
     };
 
-    document.getElementById("alternativeSpeedLimits").addEventListener("click", () => {
+    document.getElementById("alternativeSpeedLimits").addEventListener("click", (event) => {
         // Change icon immediately to give some feedback
         updateAltSpeedIcon(!alternativeSpeedLimits);
 
@@ -1114,8 +1114,8 @@ window.addEventListener("DOMContentLoaded", () => {
             });
     });
 
-    document.getElementById("DlInfos").addEventListener("click", () => { globalDownloadLimitFN(); });
+    document.getElementById("DlInfos").addEventListener("click", (event) => { globalDownloadLimitFN(); });
-    document.getElementById("UpInfos").addEventListener("click", () => { globalUploadLimitFN(); });
+    document.getElementById("UpInfos").addEventListener("click", (event) => { globalUploadLimitFN(); });
 
     document.getElementById("showTopToolbarLink").addEventListener("click", (e) => {
         showTopToolbar = !showTopToolbar;
@@ -1260,7 +1260,7 @@ window.addEventListener("DOMContentLoaded", () => {
             document.getElementById("mainWindowTabs").classList.add("invisible");
     };
 
-    document.getElementById("StatisticsLink").addEventListener("click", () => { StatisticsLinkFN(); });
+    document.getElementById("StatisticsLink").addEventListener("click", (event) => { StatisticsLinkFN(); });
 
     // main window tabs
 
@@ -1618,7 +1618,7 @@ window.addEventListener("DOMContentLoaded", () => {
 
     // listen for changes to torrentsFilterInput
     let torrentsFilterInputTimer = -1;
-    document.getElementById("torrentsFilterInput").addEventListener("input", () => {
+    document.getElementById("torrentsFilterInput").addEventListener("input", (event) => {
         clearTimeout(torrentsFilterInputTimer);
         torrentsFilterInputTimer = setTimeout(() => {
             torrentsFilterInputTimer = -1;
@@ -1628,10 +1628,10 @@ window.addEventListener("DOMContentLoaded", () => {
 
     document.getElementById("torrentsFilterToolbar").addEventListener("change", (e) => { torrentsTable.updateTable(); });
 
-    document.getElementById("transfersTabLink").addEventListener("click", () => { showTransfersTab(); });
+    document.getElementById("transfersTabLink").addEventListener("click", (event) => { showTransfersTab(); });
-    document.getElementById("searchTabLink").addEventListener("click", () => { showSearchTab(); });
+    document.getElementById("searchTabLink").addEventListener("click", (event) => { showSearchTab(); });
-    document.getElementById("rssTabLink").addEventListener("click", () => { showRssTab(); });
+    document.getElementById("rssTabLink").addEventListener("click", (event) => { showRssTab(); });
-    document.getElementById("logTabLink").addEventListener("click", () => { showLogTab(); });
+    document.getElementById("logTabLink").addEventListener("click", (event) => { showLogTab(); });
     updateTabDisplay();
 
     const registerDragAndDrop = () => {
@@ -1793,7 +1793,7 @@ window.addEventListener("DOMContentLoaded", () => {
     });
 });
 
-window.addEventListener("load", async () => {
+window.addEventListener("load", async (event) => {
     await window.qBittorrent.Client.initializeCaches();
 
     // switch to previously used tab

src/webui/www/private/scripts/contextmenu.js

@@ -219,7 +219,7 @@ window.qBittorrent.ContextMenu ??= (() => {
             });
 
             // hide on body click
-            document.body.addEventListener("click", () => {
+            document.body.addEventListener("click", (event) => {
                 this.hide();
                 this.options.element = null;
             });
@@ -483,7 +483,7 @@ window.qBittorrent.ContextMenu ??= (() => {
             const createMenuItem = (text, imgURL, clickFn) => {
                 const anchor = document.createElement("a");
                 anchor.textContent = text;
-                anchor.addEventListener("click", () => { clickFn(); });
+                anchor.addEventListener("click", clickFn);
 
                 const img = document.createElement("img");
                 img.src = imgURL;
@@ -495,8 +495,8 @@ window.qBittorrent.ContextMenu ??= (() => {
 
                 return item;
             };
-            contextCategoryList.appendChild(createMenuItem("QBT_TR(New...)QBT_TR[CONTEXT=TransferListWidget]", "images/list-add.svg", torrentNewCategoryFN));
+            contextCategoryList.appendChild(createMenuItem("QBT_TR(New...)QBT_TR[CONTEXT=TransferListWidget]", "images/list-add.svg", (event) => { torrentNewCategoryFN(); }));
-            contextCategoryList.appendChild(createMenuItem("QBT_TR(Reset)QBT_TR[CONTEXT=TransferListWidget]", "images/edit-clear.svg", () => { torrentSetCategoryFN(""); }));
+            contextCategoryList.appendChild(createMenuItem("QBT_TR(Reset)QBT_TR[CONTEXT=TransferListWidget]", "images/edit-clear.svg", (event) => { torrentSetCategoryFN(""); }));
 
             const sortedCategories = [...categories.keys()];
             sortedCategories.sort(window.qBittorrent.Misc.naturalSortCollator.compare);
@@ -533,7 +533,7 @@ window.qBittorrent.ContextMenu ??= (() => {
             const createMenuItem = (text, imgURL, clickFn) => {
                 const anchor = document.createElement("a");
                 anchor.textContent = text;
-                anchor.addEventListener("click", () => { clickFn(); });
+                anchor.addEventListener("click", clickFn);
 
                 const img = document.createElement("img");
                 img.src = imgURL;
@@ -545,8 +545,8 @@ window.qBittorrent.ContextMenu ??= (() => {
 
                 return item;
             };
-            contextTagList.appendChild(createMenuItem("QBT_TR(Add...)QBT_TR[CONTEXT=TransferListWidget]", "images/list-add.svg", torrentAddTagsFN));
+            contextTagList.appendChild(createMenuItem("QBT_TR(Add...)QBT_TR[CONTEXT=TransferListWidget]", "images/list-add.svg", (event) => { torrentAddTagsFN(); }));
-            contextTagList.appendChild(createMenuItem("QBT_TR(Remove All)QBT_TR[CONTEXT=TransferListWidget]", "images/edit-clear.svg", torrentRemoveAllTagsFN));
+            contextTagList.appendChild(createMenuItem("QBT_TR(Remove All)QBT_TR[CONTEXT=TransferListWidget]", "images/edit-clear.svg", (event) => { torrentRemoveAllTagsFN(); }));
 
             const sortedTags = [...tags.keys()];
             sortedTags.sort(window.qBittorrent.Misc.naturalSortCollator.compare);

src/webui/www/private/scripts/download.js

@@ -131,7 +131,7 @@ window.qBittorrent.Download ??= (() => {
         }
     };
 
-    window.addEventListener("load", async () => {
+    window.addEventListener("load", async (event) => {
         // user might load this page directly (via browser magnet handler)
         // so wait for crucial initialization to complete
         await window.parent.qBittorrent.Client.initializeCaches();

src/webui/www/private/scripts/pathAutofill.js

@@ -76,13 +76,13 @@ window.qBittorrent.pathAutofill ??= (() => {
     function attachPathAutofill() {
         const directoryInputs = document.querySelectorAll(".pathDirectory:not(.pathAutoFillInitialized)");
         for (const input of directoryInputs) {
-            input.addEventListener("input", function() { showPathSuggestions(this, "dirs"); });
+            input.addEventListener("input", function(event) { showPathSuggestions(this, "dirs"); });
             input.classList.add("pathAutoFillInitialized");
         }
 
         const fileInputs = document.querySelectorAll(".pathFile:not(.pathAutoFillInitialized)");
         for (const input of fileInputs) {
-            input.addEventListener("input", function() { showPathSuggestions(this, "all"); });
+            input.addEventListener("input", function(event) { showPathSuggestions(this, "all"); });
             input.classList.add("pathAutoFillInitialized");
         }
     }

src/webui/www/private/scripts/prop-files.js

@@ -586,7 +586,7 @@ window.qBittorrent.PropFiles ??= (() => {
 
     // listen for changes to torrentFilesFilterInput
     let torrentFilesFilterInputTimer = -1;
-    document.getElementById("torrentFilesFilterInput").addEventListener("input", () => {
+    document.getElementById("torrentFilesFilterInput").addEventListener("input", (event) => {
         clearTimeout(torrentFilesFilterInputTimer);
 
         const value = document.getElementById("torrentFilesFilterInput").value;

src/webui/www/private/scripts/search.js

@@ -128,7 +128,7 @@ window.qBittorrent.Search ??= (() => {
 
         // listen for changes to searchInNameFilter
         let searchInNameFilterTimer = -1;
-        document.getElementById("searchInNameFilter").addEventListener("input", () => {
+        document.getElementById("searchInNameFilter").addEventListener("input", (event) => {
             clearTimeout(searchInNameFilterTimer);
             searchInNameFilterTimer = setTimeout(() => {
                 searchInNameFilterTimer = -1;

src/webui/www/private/setlocation.html

@@ -13,7 +13,7 @@
     <script>
         "use strict";
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/shareratio.html

@@ -15,7 +15,7 @@
         const UseGlobalLimit = -2;
         const NoLimit = -1;
 
-        window.addEventListener("DOMContentLoaded", () => {
+        window.addEventListener("DOMContentLoaded", (event) => {
             window.addEventListener("keydown", (event) => {
                 switch (event.key) {
                     case "Enter":

src/webui/www/private/upload.html

@@ -160,7 +160,7 @@
 
         let submitted = false;
 
-        document.getElementById("uploadForm").addEventListener("submit", () => {
+        document.getElementById("uploadForm").addEventListener("submit", (event) => {
             document.getElementById("startTorrentHidden").value = document.getElementById("startTorrent").checked ? "false" : "true";
 
             document.getElementById("dlLimitHidden").value = Number(document.getElementById("dlLimitText").value) * 1024;
@@ -170,7 +170,7 @@
             submitted = true;
         });
 
-        document.getElementById("upload_frame").addEventListener("load", () => {
+        document.getElementById("upload_frame").addEventListener("load", (event) => {
             if (submitted)
                 window.parent.qBittorrent.Client.closeFrameWindow(window);
         });

src/webui/www/private/views/aboutToolbar.html

@@ -16,32 +16,32 @@
     (() => {
         MochaUI.initializeTabs("aboutTabs");
 
-        document.getElementById("aboutAboutLink").addEventListener("click", () => {
+        document.getElementById("aboutAboutLink").addEventListener("click", (event) => {
             Array.prototype.forEach.call(document.querySelectorAll(".aboutTabContent"), (tab => tab.classList.add("invisible")));
             document.getElementById("aboutAboutContent").classList.remove("invisible");
         });
 
-        document.getElementById("aboutAuthorLink").addEventListener("click", () => {
+        document.getElementById("aboutAuthorLink").addEventListener("click", (event) => {
             Array.prototype.forEach.call(document.querySelectorAll(".aboutTabContent"), (tab => tab.classList.add("invisible")));
             document.getElementById("aboutAuthorContent").classList.remove("invisible");
         });
 
-        document.getElementById("aboutSpecialThanksLink").addEventListener("click", () => {
+        document.getElementById("aboutSpecialThanksLink").addEventListener("click", (event) => {
             Array.prototype.forEach.call(document.querySelectorAll(".aboutTabContent"), (tab => tab.classList.add("invisible")));
             document.getElementById("aboutSpecialThanksContent").classList.remove("invisible");
         });
 
-        document.getElementById("aboutTranslatorsLink").addEventListener("click", () => {
+        document.getElementById("aboutTranslatorsLink").addEventListener("click", (event) => {
             Array.prototype.forEach.call(document.querySelectorAll(".aboutTabContent"), (tab => tab.classList.add("invisible")));
             document.getElementById("aboutTranslatorsContent").classList.remove("invisible");
         });
 
-        document.getElementById("aboutLicenseLink").addEventListener("click", () => {
+        document.getElementById("aboutLicenseLink").addEventListener("click", (event) => {
             Array.prototype.forEach.call(document.querySelectorAll(".aboutTabContent"), (tab => tab.classList.add("invisible")));
             document.getElementById("aboutLicenseContent").classList.remove("invisible");
         });
 
-        document.getElementById("aboutSoftwareUsedLink").addEventListener("click", () => {
+        document.getElementById("aboutSoftwareUsedLink").addEventListener("click", (event) => {
             Array.prototype.forEach.call(document.querySelectorAll(".aboutTabContent"), (tab => tab.classList.add("invisible")));
             document.getElementById("aboutSoftwareUsedContent").classList.remove("invisible");
         });

src/webui/www/private/views/preferences.html

@@ -3167,7 +3167,7 @@ Use ';' to split multiple entries. Can use wildcard '*'.)QBT_TR[CONTEXT=OptionsD
             if ((buildInfo.platform !== "macos") && (buildInfo.platform !== "windows"))
                 document.getElementById("rowMarkOfTheWeb").style.display = "none";
 
-            document.getElementById("networkInterface").addEventListener("change", function() {
+            document.getElementById("networkInterface").addEventListener("change", function(event) {
                 updateInterfaceAddresses(this.value, "");
             });
 

src/webui/www/private/views/rssDownloader.html

@@ -475,8 +475,8 @@ Supports the formats: S01E01, 1x1, 2017.12.31 and 31.12.2017 (Date formats also
                     };
                     flatten(responseJSON);
                 });
-            document.getElementById("savetoDifferentDir").addEventListener("click", () => {
+            document.getElementById("savetoDifferentDir").addEventListener("click", (event) => {
-                document.getElementById("saveToText").disabled = !document.getElementById("savetoDifferentDir").checked;
+                document.getElementById("saveToText").disabled = !event.target.checked;
             });
             updateRulesList();
         };