Use switch statement

PR #22247.
This commit is contained in:
Chocobo1 2025-02-08 17:39:10 +08:00 committed by GitHub
parent f8469d02f7
commit e55b59d9ca
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -392,7 +392,9 @@ void TrackersFilterWidget::handleTrackerStatusesUpdated(const BitTorrent::Torren
for (const BitTorrent::TrackerEntryStatus &trackerEntryStatus : updatedTrackers) for (const BitTorrent::TrackerEntryStatus &trackerEntryStatus : updatedTrackers)
{ {
if (trackerEntryStatus.state == BitTorrent::TrackerEndpointState::Working) switch (trackerEntryStatus.state)
{
case BitTorrent::TrackerEndpointState::Working:
{ {
// remove tracker from "error" and "tracker error" categories // remove tracker from "error" and "tracker error" categories
if (errorHashesIt != m_errors.end()) if (errorHashesIt != m_errors.end())
@ -419,8 +421,10 @@ void TrackersFilterWidget::handleTrackerStatusesUpdated(const BitTorrent::Torren
warningHashesIt->insert(trackerEntryStatus.url); warningHashesIt->insert(trackerEntryStatus.url);
} }
} }
else if ((trackerEntryStatus.state == BitTorrent::TrackerEndpointState::NotWorking) break;
|| (trackerEntryStatus.state == BitTorrent::TrackerEndpointState::Unreachable))
case BitTorrent::TrackerEndpointState::NotWorking:
case BitTorrent::TrackerEndpointState::Unreachable:
{ {
// remove tracker from "tracker error" and "warning" categories // remove tracker from "tracker error" and "warning" categories
if (warningHashesIt != m_warnings.end()) if (warningHashesIt != m_warnings.end())
@ -432,7 +436,9 @@ void TrackersFilterWidget::handleTrackerStatusesUpdated(const BitTorrent::Torren
errorHashesIt = m_errors.insert(id, {}); errorHashesIt = m_errors.insert(id, {});
errorHashesIt->insert(trackerEntryStatus.url); errorHashesIt->insert(trackerEntryStatus.url);
} }
else if (trackerEntryStatus.state == BitTorrent::TrackerEndpointState::TrackerError) break;
case BitTorrent::TrackerEndpointState::TrackerError:
{ {
// remove tracker from "error" and "warning" categories // remove tracker from "error" and "warning" categories
if (warningHashesIt != m_warnings.end()) if (warningHashesIt != m_warnings.end())
@ -444,7 +450,9 @@ void TrackersFilterWidget::handleTrackerStatusesUpdated(const BitTorrent::Torren
trackerErrorHashesIt = m_trackerErrors.insert(id, {}); trackerErrorHashesIt = m_trackerErrors.insert(id, {});
trackerErrorHashesIt->insert(trackerEntryStatus.url); trackerErrorHashesIt->insert(trackerEntryStatus.url);
} }
else if (trackerEntryStatus.state == BitTorrent::TrackerEndpointState::NotContacted) break;
case BitTorrent::TrackerEndpointState::NotContacted:
{ {
// remove tracker from "error", "tracker error" and "warning" categories // remove tracker from "error", "tracker error" and "warning" categories
if (warningHashesIt != m_warnings.end()) if (warningHashesIt != m_warnings.end())
@ -454,6 +462,11 @@ void TrackersFilterWidget::handleTrackerStatusesUpdated(const BitTorrent::Torren
if (trackerErrorHashesIt != m_trackerErrors.end()) if (trackerErrorHashesIt != m_trackerErrors.end())
trackerErrorHashesIt->remove(trackerEntryStatus.url); trackerErrorHashesIt->remove(trackerEntryStatus.url);
} }
break;
case BitTorrent::TrackerEndpointState::Updating:
break;
};
} }
if ((errorHashesIt != m_errors.end()) && errorHashesIt->isEmpty()) if ((errorHashesIt != m_errors.end()) && errorHashesIt->isEmpty())