github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 13:23:34 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Properly release settings class before further operations

Browse source 
Fix up d3e7e8a630.

PR #17376.
This commit is contained in:
Chocobo1 2022-07-17 12:41:18 +08:00 • committed by GitHub
commit e281b667c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/base/settingsstorage.cpp
View file

@ -172,8 +172,12 @@ bool SettingsStorage::writeNativeSettings() const
nativeSettings->setValue(i.key(), i.value());
nativeSettings->sync(); // Important to get error status
const QSettings::Status status = nativeSettings->status();
const Path newPath {nativeSettings->fileName()};
switch (nativeSettings->status())
nativeSettings.reset(); // close QSettings
switch (status)
{
case QSettings::NoError:
break;
@ -188,8 +192,7 @@ bool SettingsStorage::writeNativeSettings() const
break;
}
const Path newPath {nativeSettings->fileName()};
if (nativeSettings->status() != QSettings::NoError)
if (status != QSettings::NoError)
{
Utils::Fs::removeFile(newPath);
return false;