github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-21 05:43:32 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check header after request succeeds, check if added trackers are valid URL\'s

Browse source
This commit is contained in:
Stiliyan Tonev (Bark) 2025-01-10 13:58:14 +02:00
commit db41945db7
2 changed files with 30 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/gui/trackersadditiondialog.cpp
View file

@ -74,14 +74,35 @@ TrackersAdditionDialog::~TrackersAdditionDialog()
delete m_ui;
}
int TrackersAdditionDialog::isValidEndpoint(const QStringView &endpoint) const
{
if (endpoint.isEmpty())
return 0;
QUrl url(endpoint.toString());
if (!url.isValid())
return 0;
if (url.scheme().isEmpty())
return 0;
if (url.host().isEmpty())
return 0;
return 1;
}
void TrackersAdditionDialog::onAccepted() const
{
const QList<BitTorrent::TrackerEntryStatus> currentTrackers = m_torrent->trackers();
const int baseTier = !currentTrackers.isEmpty() ? (currentTrackers.last().tier + 1) : 0;
QList<BitTorrent::TrackerEntry> entries = BitTorrent::parseTrackerEntries(m_ui->textEditTrackersList->toPlainText());
for (BitTorrent::TrackerEntry &entry : entries)
for (BitTorrent::TrackerEntry &entry : entries) {
auto isValid = isValidEndpoint(entry.url);
if (!isValid)
{
QMessageBox::warning(const_cast<TrackersAdditionDialog *>(this), tr("Invalid tracker URL"), tr("The tracker URL \"%1\" is invalid").arg(entry.url));
return;
}
entry.tier = Utils::Number::clampingAdd(entry.tier, baseTier);
}
m_torrent->addTrackers(entries);
}
@ -109,13 +130,6 @@ void TrackersAdditionDialog::onTorrentListDownloadFinished(const Net::DownloadRe
m_ui->downloadButton->setEnabled(true);
setCursor(Qt::ArrowCursor);
if (!result.contentType.contains(u"text/plain"_s, Qt::CaseInsensitive))
{
QMessageBox::warning(this, tr("Download trackers list error")
, tr("The content type of the downloaded file is not plain text. Content-Type: \"%1\"").arg(result.contentType));
return;
}
if (result.status != Net::DownloadStatus::Success)
{
QMessageBox::warning(this, tr("Download trackers list error")
@ -123,6 +137,13 @@ void TrackersAdditionDialog::onTorrentListDownloadFinished(const Net::DownloadRe
return;
}
if (!result.contentType.contains(u"text/plain"_s, Qt::CaseInsensitive))
{
QMessageBox::warning(this, tr("Download trackers list error")
, tr("The content type of the downloaded file is not plain text. Content-Type: \"%1\"").arg(result.contentType));
return;
}
// Add fetched trackers to the list
const QString existingText = m_ui->textEditTrackersList->toPlainText();
if (!existingText.isEmpty() && !existingText.endsWith(u'\n'))

1
src/gui/trackersadditiondialog.h
View file

@ -65,6 +65,7 @@ private slots:
private:
void saveSettings();
void loadSettings();
int isValidEndpoint(const QStringView &endpoint) const;
Ui::TrackersAdditionDialog *m_ui = nullptr;
BitTorrent::Torrent *const m_torrent = nullptr;