github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-14 17:23:07 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Enhancement of the webui preference and of the quote escape for javascript

Browse source
This commit is contained in:
racam 2015-04-27 20:44:12 +02:00
parent 80b526d1af
commit d7ac142885
3 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/app/application.cpp
View file

@ -157,16 +157,14 @@ int Application::exec(const QStringList &params)
#ifdef DISABLE_GUI #ifdef DISABLE_GUI
#ifndef DISABLE_WEBUI #ifndef DISABLE_WEBUI
Preferences* const pref = Preferences::instance(); Preferences* const pref = Preferences::instance();
if (pref->isWebUiEnabled()) { // Display some information to the user
// Display some information to the user std::cout << std::endl << "******** " << qPrintable(tr("Information")) << " ********" << std::endl;
std::cout << std::endl << "******** " << qPrintable(tr("Information")) << " ********" << std::endl; std::cout << qPrintable(tr("To control qBittorrent, access the Web UI at http://localhost:%1").arg(QString::number(pref->getWebUiPort()))) << std::endl;
std::cout << qPrintable(tr("To control qBittorrent, access the Web UI at http://localhost:%1").arg(QString::number(pref->getWebUiPort()))) << std::endl; std::cout << qPrintable(tr("The Web UI administrator user name is: %1").arg(pref->getWebUiUsername())) << std::endl;
std::cout << qPrintable(tr("The Web UI administrator user name is: %1").arg(pref->getWebUiUsername())) << std::endl; qDebug() << "Password:" << pref->getWebUiPassword();
qDebug() << "Password:" << pref->getWebUiPassword(); if (pref->getWebUiPassword() == "f6fdffe48c908deb0f4c3bd36c032e72") {
if (pref->getWebUiPassword() == "f6fdffe48c908deb0f4c3bd36c032e72") { std::cout << qPrintable(tr("The Web UI administrator password is still the default one: %1").arg("adminadmin")) << std::endl;
std::cout << qPrintable(tr("The Web UI administrator password is still the default one: %1").arg("adminadmin")) << std::endl; std::cout << qPrintable(tr("This is a security risk, please consider changing your password from program preferences.")) << std::endl;
std::cout << qPrintable(tr("This is a security risk, please consider changing your password from program preferences.")) << std::endl;
}
} }
#endif // DISABLE_WEBUI #endif // DISABLE_WEBUI
#else #else

4
src/core/preferences.cpp
View file

@ -1076,7 +1076,11 @@ void Preferences::setIgnoreSlowTorrentsForQueueing(bool ignore)
bool Preferences::isWebUiEnabled() const bool Preferences::isWebUiEnabled() const
{ {
#ifdef DISABLE_GUI
return true;
#else
return value("Preferences/WebUI/Enabled", false).toBool(); return value("Preferences/WebUI/Enabled", false).toBool();
#endif
} }
void Preferences::setWebUiEnabled(bool enabled) void Preferences::setWebUiEnabled(bool enabled)

4
src/webui/abstractwebapplication.cpp
View file

@ -270,6 +270,10 @@ void AbstractWebApplication::translateDocument(QString& data)
// Remove keyboard shortcuts // Remove keyboard shortcuts
translation.replace(mnemonic, ""); translation.replace(mnemonic, "");
// Use HTML code for quotes to prevent issues with JS
translation.replace("'", "&#39;");
translation.replace("\"", "&#34;");
data.replace(i, regex.matchedLength(), translation); data.replace(i, regex.matchedLength(), translation);
i += translation.length(); i += translation.length();
} }