From cbc0e2527a73fdad9c6473a29e473d7b4d140bda Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Sun, 10 May 2015 15:16:37 +0800 Subject: [PATCH] Fix potential negative loop bound. QTorrentHandle::num_files() could return -1 in these cases. --- src/core/qtlibtorrent/qtorrenthandle.cpp | 4 ++-- src/gui/previewselect.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/qtlibtorrent/qtorrenthandle.cpp b/src/core/qtlibtorrent/qtorrenthandle.cpp index 79c923e1d..0e40e7bce 100644 --- a/src/core/qtlibtorrent/qtorrenthandle.cpp +++ b/src/core/qtlibtorrent/qtorrenthandle.cpp @@ -732,8 +732,8 @@ void QTorrentHandle::prioritize_first_last_piece(bool b) const { if (!has_metadata()) return; // Download first and last pieces first for all media files in the torrent - const uint nbfiles = num_files(); - for (uint index = 0; index < nbfiles; ++index) { + const int nbfiles = num_files(); + for (int index = 0; index < nbfiles; ++index) { const QString path = filepath_at(index); const QString ext = fsutils::fileExtension(path); if (misc::isPreviewable(ext) && torrent_handle::file_priority(index) > 0) { diff --git a/src/gui/previewselect.cpp b/src/gui/previewselect.cpp index d52177994..8d7fb015d 100644 --- a/src/gui/previewselect.cpp +++ b/src/gui/previewselect.cpp @@ -60,8 +60,8 @@ PreviewSelect::PreviewSelect(QWidget* parent, QTorrentHandle h): QDialog(parent) // Fill list in std::vector fp; h.file_progress(fp); - unsigned int nbFiles = h.num_files(); - for (unsigned int i=0; i