github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-07-16 02:03:07 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make modifying log file perms best effort

Browse source 
qBittorrent is able to write to the log file, so it's ok if the permission change fails.

PR #22800.
This commit is contained in:
Thomas Piccirello 2025-06-05 02:32:26 -07:00 • committed by GitHub
parent 0c48b70e5b
commit c59ac3b970
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/app/filelogger.cpp
View file

@ -175,12 +175,15 @@ void FileLogger::flushLog()
void FileLogger::openLogFile() void FileLogger::openLogFile()
{ {
if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text) if (!m_logFile.open(QIODevice::WriteOnly | QIODevice::Append | QIODevice::Text))
|| !m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner))
{ {
m_logFile.close(); LogMsg(tr("An error occurred while trying to open the log file. Logging to file is disabled. File: \"%1\". Error: \"%2\".")
LogMsg(tr("An error occurred while trying to open the log file. Logging to file is disabled."), Log::CRITICAL); .arg(m_logFile.fileName(), m_logFile.errorString()), Log::CRITICAL);
return;
} }
// best effort, don't report error
m_logFile.setPermissions(QFile::ReadOwner | QFile::WriteOwner);
} }
void FileLogger::closeLogFile() void FileLogger::closeLogFile()