Call QPromise::start() early to avoid race condition

PR #22617.
This commit is contained in:
Vladimir Golovnev 2025-04-28 17:26:51 +03:00 committed by sledgehammer999
parent ad4bdc0653
commit c2f2a38582
No known key found for this signature in database
GPG key ID: 6E4A2D025B7CC9A2
4 changed files with 6 additions and 7 deletions

View file

@ -63,10 +63,8 @@ namespace
}
void FileSearcher::search(const PathList &originalFileNames, const Path &savePath
, const Path &downloadPath, const bool forceAppendExt, QPromise<FileSearchResult> promise)
, const Path &downloadPath, const bool forceAppendExt, QPromise<FileSearchResult> &promise)
{
promise.start();
Path usedPath = savePath;
PathList adjustedFileNames = originalFileNames;
const bool found = findInDir(usedPath, adjustedFileNames, (forceAppendExt && downloadPath.isEmpty()));
@ -77,5 +75,4 @@ void FileSearcher::search(const PathList &originalFileNames, const Path &savePat
}
promise.addResult(FileSearchResult {.savePath = usedPath, .fileNames = adjustedFileNames});
promise.finish();
}