From c194b4512d2a9d02f0448c14e1ad85c14d824c77 Mon Sep 17 00:00:00 2001
From: "Stiliyan Tonev (Bark)" <stiliyan21@gmail.com>
Date: Mon, 31 Mar 2025 14:07:01 +0300
Subject: [PATCH] Address PR comments.

---
 src/base/net/downloadmanager.h     |  2 +-
 src/gui/optionsdialog.cpp          | 15 ++++++---------
 src/gui/optionsdialog.h            |  4 +++-
 src/gui/trackersadditiondialog.cpp | 24 ++++++++++++------------
 src/gui/trackersadditiondialog.h   |  3 +--
 5 files changed, 23 insertions(+), 25 deletions(-)

diff --git a/src/base/net/downloadmanager.h b/src/base/net/downloadmanager.h
index a13768e9d..b1cf32425 100644
--- a/src/base/net/downloadmanager.h
+++ b/src/base/net/downloadmanager.h
@@ -104,10 +104,10 @@ namespace Net
         QString url;
         DownloadStatus status = DownloadStatus::Failed;
         QString errorString;
+        QString contentType;
         QByteArray data;
         Path filePath;
         QString magnetURI;
-        QString contentType;
     };
 
     class DownloadHandler : public QObject
diff --git a/src/gui/optionsdialog.cpp b/src/gui/optionsdialog.cpp
index d62a16f72..517173cf8 100644
--- a/src/gui/optionsdialog.cpp
+++ b/src/gui/optionsdialog.cpp
@@ -53,7 +53,6 @@
 #include "base/bittorrent/sharelimitaction.h"
 #include "base/exceptions.h"
 #include "base/global.h"
-#include "base/net/downloadmanager.h"
 #include "base/net/portforwarder.h"
 #include "base/net/proxyconfigurationmanager.h"
 #include "base/path.h"
@@ -1233,21 +1232,21 @@ void OptionsDialog::saveBittorrentTabOptions() const
     session->setAddTrackersEnabled(m_ui->checkEnableAddTrackers->isChecked());
     session->setAdditionalTrackers(m_ui->textTrackers->toPlainText());
 
-    auto enabledAddTrackers = m_ui->checkAddTrackersFromURL->isChecked();
-    auto url = m_ui->textTrackersURL->text();
-    if (!url.isEmpty() && enabledAddTrackers)
+    const bool isAddTrackersEnabled = m_ui->checkAddTrackersFromURL->isChecked();
+    const QString url = m_ui->textTrackersURL->text();
+    if (isAddTrackersEnabled && !url.isEmpty())
     {
         Net::DownloadManager::instance()->download(url, Preferences::instance()->useProxyForGeneralPurposes()
-            , this, &OptionsDialog::onAddTrackersDownload);
+            , this, &OptionsDialog::onAdditionalTrackersDownload);
     }
     else
     {
-        session->setAddTrackersFromURLEnabled(enabledAddTrackers);
+        session->setAddTrackersFromURLEnabled(isAddTrackersEnabled);
         session->setAdditionalTrackersURL(url);
     }
 }
 
-void OptionsDialog::onAddTrackersDownload(const Net::DownloadResult &result)
+void OptionsDialog::onAdditionalTrackersDownload(const Net::DownloadResult &result)
 {
     if (result.status != Net::DownloadStatus::Success)
     {
@@ -1267,8 +1266,6 @@ void OptionsDialog::onAddTrackersDownload(const Net::DownloadResult &result)
 
     session->setAddTrackersFromURLEnabled(m_ui->checkAddTrackersFromURL->isChecked());
     session->setAdditionalTrackersURL(m_ui->textTrackersURL->text());
-
-    return;
 }
 
 void OptionsDialog::loadRSSTabOptions()
diff --git a/src/gui/optionsdialog.h b/src/gui/optionsdialog.h
index d6d7d1a6d..6828c2ce4 100644
--- a/src/gui/optionsdialog.h
+++ b/src/gui/optionsdialog.h
@@ -31,10 +31,10 @@
 
 #include <QDialog>
 
+#include "base/net/downloadmanager.h"
 #include "base/pathfwd.h"
 #include "base/settingvalue.h"
 #include "guiapplicationcomponent.h"
-#include "base/net/downloadmanager.h"
 
 class QListWidgetItem;
 
@@ -138,6 +138,8 @@ private:
     void loadRSSTabOptions();
     void saveRSSTabOptions() const;
 
+    void onAdditionalTrackersDownload(const Net::DownloadResult &result);
+
     void loadSearchTabOptions();
     void saveSearchTabOptions() const;
 
diff --git a/src/gui/trackersadditiondialog.cpp b/src/gui/trackersadditiondialog.cpp
index 9403edf3b..2ae916370 100644
--- a/src/gui/trackersadditiondialog.cpp
+++ b/src/gui/trackersadditiondialog.cpp
@@ -74,31 +74,31 @@ TrackersAdditionDialog::~TrackersAdditionDialog()
     delete m_ui;
 }
 
-int TrackersAdditionDialog::isValidEndpoint(const QStringView &endpoint) const
+bool isValidEndpoint(const QStringView endpoint)
 {
     if (endpoint.isEmpty())
-        return 0;
-    QUrl url(endpoint.toString());
+        return false;
+    const QUrl url {endpoint.toString()};
     if (!url.isValid())
-        return 0;
+        return false;
     if (url.scheme().isEmpty())
-        return 0;
+        return false;
     if (url.host().isEmpty())
-        return 0;
-    return 1;
+        return false;
+    return true;
 }
 
-void TrackersAdditionDialog::onAccepted() const
+void TrackersAdditionDialog::onAccepted()
 {
     const QList<BitTorrent::TrackerEntryStatus> currentTrackers = m_torrent->trackers();
     const int baseTier = !currentTrackers.isEmpty() ? (currentTrackers.last().tier + 1) : 0;
 
     QList<BitTorrent::TrackerEntry> entries = BitTorrent::parseTrackerEntries(m_ui->textEditTrackersList->toPlainText());
-    for (BitTorrent::TrackerEntry &entry : entries) {
-        auto isValid = isValidEndpoint(entry.url);
-        if (!isValid)
+    for (BitTorrent::TrackerEntry &entry : entries)
+    {
+        if (!isValidEndpoint(entry.url))
         {
-            QMessageBox::warning(const_cast<TrackersAdditionDialog *>(this), tr("Invalid tracker URL"), tr("The tracker URL \"%1\" is invalid").arg(entry.url));
+            QMessageBox::warning(this, tr("Invalid tracker URL"), tr("The tracker URL \"%1\" is invalid").arg(entry.url));
             return;
         }
         entry.tier = Utils::Number::clampingAdd(entry.tier, baseTier);
diff --git a/src/gui/trackersadditiondialog.h b/src/gui/trackersadditiondialog.h
index 893379f68..ebb214050 100644
--- a/src/gui/trackersadditiondialog.h
+++ b/src/gui/trackersadditiondialog.h
@@ -58,14 +58,13 @@ public:
     ~TrackersAdditionDialog();
 
 private slots:
-    void onAccepted() const;
+    void onAccepted();
     void onDownloadButtonClicked();
     void onTorrentListDownloadFinished(const Net::DownloadResult &result);
 
 private:
     void saveSettings();
     void loadSettings();
-    int isValidEndpoint(const QStringView &endpoint) const;
 
     Ui::TrackersAdditionDialog *m_ui = nullptr;
     BitTorrent::Torrent *const m_torrent = nullptr;