From bb73fa5dbe57c8d17a7d4374475ef355b46d033e Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Wed, 18 Dec 2019 15:05:42 +0800 Subject: [PATCH] Replace a series of `if()` by `switch()` --- src/gui/transferlistfilterswidget.cpp | 14 ++++++++------ src/gui/transferlistfilterswidget.h | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gui/transferlistfilterswidget.cpp b/src/gui/transferlistfilterswidget.cpp index 9ff3d4097..529197d9b 100644 --- a/src/gui/transferlistfilterswidget.cpp +++ b/src/gui/transferlistfilterswidget.cpp @@ -583,16 +583,18 @@ QString TrackerFiltersList::getHost(const QString &tracker) const return longHost.mid(index + 1); } -QStringList TrackerFiltersList::getHashes(int row) +QStringList TrackerFiltersList::getHashes(const int row) const { - if (row == 1) + switch (row) { + case 1: return m_trackers.value(""); - if (row == 2) + case 2: return m_errors.keys(); - if (row == 3) + case 3: return m_warnings.keys(); - - return m_trackers.value(trackerFromRow(row)); + default: + return m_trackers.value(trackerFromRow(row)); + } } TransferListFiltersWidget::TransferListFiltersWidget(QWidget *parent, TransferListWidget *transferList, const bool downloadFavicon) diff --git a/src/gui/transferlistfilterswidget.h b/src/gui/transferlistfilterswidget.h index b3d42acb3..4d8c49564 100644 --- a/src/gui/transferlistfilterswidget.h +++ b/src/gui/transferlistfilterswidget.h @@ -126,7 +126,7 @@ private: QString trackerFromRow(int row) const; int rowFromTracker(const QString &tracker) const; QString getHost(const QString &tracker) const; - QStringList getHashes(int row); + QStringList getHashes(int row) const; void downloadFavicon(const QString &url); QHash m_trackers;