github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-20 05:13:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refact: Return removed if and apply suggested improvements

Browse source
This commit is contained in:
Stiliyan Tonev (Bark) 2025-05-27 14:12:57 +03:00
commit b9d3805a65
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/webui/www/private/scripts/dynamicTable.js
View file

@ -1005,7 +1005,8 @@ window.qBittorrent.DynamicTable ??= (() => {
tds[i].style.width = `${this.columns[i].width}px`; tds[i].style.width = `${this.columns[i].width}px`;
tds[i].style.maxWidth = `${this.columns[i].width}px`; tds[i].style.maxWidth = `${this.columns[i].width}px`;
} }
this.columns[i].updateTd(tds[i], row); if (this.columns[i].dataProperties.some(prop => Object.hasOwn(data, prop)))
this.columns[i].updateTd(tds[i], row);
} }
row["data"] = {}; row["data"] = {};
} }
@ -1151,6 +1152,7 @@ window.qBittorrent.DynamicTable ??= (() => {
this.columns["num_seeds"].dataProperties.push("num_complete"); this.columns["num_seeds"].dataProperties.push("num_complete");
this.columns["num_leechs"].dataProperties.push("num_incomplete"); this.columns["num_leechs"].dataProperties.push("num_incomplete");
this.columns["time_active"].dataProperties.push("seeding_time"); this.columns["time_active"].dataProperties.push("seeding_time");
this.columns["percent_selected"].dataProperties = ["size", "total_size", "has_metadata"];
this.initColumnsFunctions(); this.initColumnsFunctions();
} }
@ -1557,13 +1559,15 @@ window.qBittorrent.DynamicTable ??= (() => {
// percent_selected // percent_selected
this.columns["percent_selected"].updateTd = function(td, row) { this.columns["percent_selected"].updateTd = function(td, row) {
const fullData = row["full_data"]; const size = this.getRowValue(row, 0);
if (fullData["has_metadata"] === false) { const totalSize = this.getRowValue(row, 1);
const hasMetadata = this.getRowValue(row, 2);
if (hasMetadata === false) {
td.textContent = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]"; td.textContent = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]";
td.title = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]"; td.title = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]";
return; return;
} }
const percent = (fullData["size"] / fullData["total_size"]) * 100; const percent = (size / totalSize) * 100;
if (percent === -1) { if (percent === -1) {
td.textContent = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]"; td.textContent = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]";
td.title = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]"; td.title = "QBT_TR(N/A)QBT_TR[CONTEXT=TrackerListWidget]";