github/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent synced 2025-08-19 04:49:47 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix important Web UI bug (HTTP request parsing bug)

Browse source 
(cherry picked from commit bdaf16123f)
This commit is contained in:
Christophe Dumez 2012-03-18 17:16:14 +02:00
commit b93cebacb2
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/webui/httpconnection.cpp
View file

@ -84,6 +84,7 @@ void HttpConnection::read() {
// Parse HTTP request header // Parse HTTP request header
int header_end = input.indexOf("\r\n\r\n"); int header_end = input.indexOf("\r\n\r\n");
if (header_end < 0) { if (header_end < 0) {
qDebug() << "Partial request: \n" << input;
// Partial request waiting for the rest // Partial request waiting for the rest
return; return;
} }
@ -101,7 +102,6 @@ void HttpConnection::read() {
if (m_parser.header().hasContentLength()) { if (m_parser.header().hasContentLength()) {
const int expected_length = m_parser.header().contentLength(); const int expected_length = m_parser.header().contentLength();
QByteArray message = input.mid(header_end + 4, expected_length); QByteArray message = input.mid(header_end + 4, expected_length);
input = input.mid(header_end + 4 + expected_length);
if (expected_length > 100000) { if (expected_length > 100000) {
qWarning() << "Bad request: message too long"; qWarning() << "Bad request: message too long";
@ -113,10 +113,13 @@ void HttpConnection::read() {
if (message.length() < expected_length) { if (message.length() < expected_length) {
// Message too short, waiting for the rest // Message too short, waiting for the rest
qDebug() << "Partial message:\n" << message;
return; return;
} }
m_parser.writeMessage(message); m_parser.writeMessage(message);
input = input.mid(header_end + 4 + expected_length);
} else { } else {
input.clear(); input.clear();
} }