From 74a772aafbd0d4c0e99714599824a58b7540ad07 Mon Sep 17 00:00:00 2001
From: Thomas Piccirello <thomas@piccirello.com>
Date: Thu, 10 Jan 2019 15:49:35 -0800
Subject: [PATCH 1/3] Add Web UI support for escape key

---
 src/webui/www/private/addtrackers.html        | 13 ++++++++---
 src/webui/www/private/downloadlimit.html      | 22 ++++++++++++++++++-
 src/webui/www/private/edittracker.html        | 13 ++++++++---
 .../www/private/installsearchplugin.html      |  5 ++---
 src/webui/www/private/newcategory.html        | 13 ++++++++---
 src/webui/www/private/rename.html             | 13 ++++++++---
 src/webui/www/private/scripts/client.js       |  6 ++---
 src/webui/www/private/search.html             |  5 ++---
 src/webui/www/private/setlocation.html        | 13 ++++++++---
 src/webui/www/private/shareratio.html         | 13 ++++++++---
 src/webui/www/private/uploadlimit.html        | 22 ++++++++++++++++++-
 11 files changed, 108 insertions(+), 30 deletions(-)

diff --git a/src/webui/www/private/addtrackers.html b/src/webui/www/private/addtrackers.html
index 9bebf810a..5b78735a6 100644
--- a/src/webui/www/private/addtrackers.html
+++ b/src/webui/www/private/addtrackers.html
@@ -11,16 +11,23 @@
         'use strict';
 
         window.addEvent('domready', function() {
-            var setLocationKeyboardEvents = new Keyboard({
+            new Keyboard({
                 defaultEventType: 'keydown',
                 events: {
                     'enter': function(event) {
                         $('addTrackersButton').click();
                         event.preventDefault();
+                    },
+                    'Escape': function(event) {
+                        window.parent.closeWindows();
+                        event.preventDefault();
+                    },
+                    'Esc': function(event) {
+                        window.parent.closeWindows();
+                        event.preventDefault();
                     }
                 }
-            });
-            setLocationKeyboardEvents.activate();
+            }).activate();
 
             $('trackersUrls').focus();
             $('addTrackersButton').addEvent('click', function(e) {
diff --git a/src/webui/www/private/downloadlimit.html b/src/webui/www/private/downloadlimit.html
index 52b8eaaf5..08ae92e3f 100644
--- a/src/webui/www/private/downloadlimit.html
+++ b/src/webui/www/private/downloadlimit.html
@@ -55,10 +55,30 @@
                 }
             }
         </script>
-        <input type="button" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]" onclick="setDlLimit()" />
+        <input type="button" id="applyButton" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]" onclick="setDlLimit()" />
     </div>
 
     <script>
+        new Keyboard({
+            defaultEventType: 'keydown',
+            events: {
+                'enter': function(event) {
+                    $('applyButton').click();
+                    event.preventDefault();
+                },
+                'Escape': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                },
+                'Esc': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                }
+            }
+        }).activate();
+
+        $('dllimitUpdatevalue').focus();
+
         MochaUI.addDlLimitSlider(hashes);
     </script>
 
diff --git a/src/webui/www/private/edittracker.html b/src/webui/www/private/edittracker.html
index 7e1d8076f..d5162ec80 100644
--- a/src/webui/www/private/edittracker.html
+++ b/src/webui/www/private/edittracker.html
@@ -11,16 +11,23 @@
         'use strict';
 
         window.addEvent('domready', function() {
-            var setLocationKeyboardEvents = new Keyboard({
+            new Keyboard({
                 defaultEventType: 'keydown',
                 events: {
                     'enter': function(event) {
                         $('editTrackerButton').click();
                         event.preventDefault();
+                    },
+                    'Escape': function(event) {
+                        window.parent.closeWindows();
+                        event.preventDefault();
+                    },
+                    'Esc': function(event) {
+                        window.parent.closeWindows();
+                        event.preventDefault();
                     }
                 }
-            });
-            setLocationKeyboardEvents.activate();
+            }).activate();
 
             var currentUrl = new URI().getData('url');
             if (!currentUrl)
diff --git a/src/webui/www/private/installsearchplugin.html b/src/webui/www/private/installsearchplugin.html
index 7ea7b9d73..61067d245 100644
--- a/src/webui/www/private/installsearchplugin.html
+++ b/src/webui/www/private/installsearchplugin.html
@@ -30,7 +30,7 @@
     'use strict';
 
     var initInstallSearchPlugin = function() {
-        var installSearchPluginKeyboardEvents = new Keyboard({
+        new Keyboard({
             defaultEventType: 'keydown',
             events: {
                 'enter': function(e) {
@@ -44,8 +44,7 @@
                         closeSearchWindow('installSearchPlugin');
                 }
             }
-        });
-        installSearchPluginKeyboardEvents.activate();
+        }).activate();
 
         $('newPluginPath').select();
     };
diff --git a/src/webui/www/private/newcategory.html b/src/webui/www/private/newcategory.html
index ea313a44e..7e5c5dae9 100644
--- a/src/webui/www/private/newcategory.html
+++ b/src/webui/www/private/newcategory.html
@@ -11,16 +11,23 @@
     <script>
         'use strict';
 
-        var newCategoryKeyboardEvents = new Keyboard({
+        new Keyboard({
             defaultEventType: 'keydown',
             events: {
                 'enter': function(event) {
                     $('categoryNameButton').click();
                     event.preventDefault();
+                },
+                'Escape': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                },
+                'Esc': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
                 }
             }
-        });
-        newCategoryKeyboardEvents.activate();
+        }).activate();
 
         window.addEvent('domready', function() {
             var uriAction = safeTrim(new URI().getData('action'));
diff --git a/src/webui/www/private/rename.html b/src/webui/www/private/rename.html
index 5ba4b6c95..64b2df68b 100644
--- a/src/webui/www/private/rename.html
+++ b/src/webui/www/private/rename.html
@@ -11,16 +11,23 @@
     <script>
         'use strict';
 
-        var renameKeyboardEvents = new Keyboard({
+        new Keyboard({
             defaultEventType: 'keydown',
             events: {
                 'enter': function(event) {
                     $('renameButton').click();
                     event.preventDefault();
+                },
+                'Escape': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                },
+                'Esc': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
                 }
             }
-        });
-        renameKeyboardEvents.activate();
+        }).activate();
 
         window.addEvent('domready', function() {
             var name = new URI().getData('name');
diff --git a/src/webui/www/private/scripts/client.js b/src/webui/www/private/scripts/client.js
index c98c4ac55..28df65ead 100644
--- a/src/webui/www/private/scripts/client.js
+++ b/src/webui/www/private/scripts/client.js
@@ -824,7 +824,7 @@ function setupCopyEventHandler() {
     });
 }
 
-var keyboardEvents = new Keyboard({
+new Keyboard({
     defaultEventType: 'keydown',
     events: {
         'ctrl+a': function(event) {
@@ -836,6 +836,4 @@ var keyboardEvents = new Keyboard({
             event.preventDefault();
         }
     }
-});
-
-keyboardEvents.activate();
+}).activate();
diff --git a/src/webui/www/private/search.html b/src/webui/www/private/search.html
index 0821d5703..62bf59c01 100644
--- a/src/webui/www/private/search.html
+++ b/src/webui/www/private/search.html
@@ -199,7 +199,7 @@
             }
         });
 
-        var searchKeyboardEvents = new Keyboard({
+        new Keyboard({
             defaultEventType: 'keydown',
             events: {
                 'enter': function(e) {
@@ -228,8 +228,7 @@
                     }
                 }
             }
-        });
-        searchKeyboardEvents.activate();
+        }).activate();
     };
 
     var startSearch = function(pattern, category, plugins) {
diff --git a/src/webui/www/private/setlocation.html b/src/webui/www/private/setlocation.html
index bd43215eb..c819ff85b 100644
--- a/src/webui/www/private/setlocation.html
+++ b/src/webui/www/private/setlocation.html
@@ -11,16 +11,23 @@
     <script>
         'use strict';
 
-        var setLocationKeyboardEvents = new Keyboard({
+        new Keyboard({
             defaultEventType: 'keydown',
             events: {
                 'enter': function(event) {
                     $('setLocationButton').click();
                     event.preventDefault();
+                },
+                'Escape': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                },
+                'Esc': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
                 }
             }
-        });
-        setLocationKeyboardEvents.activate();
+        }).activate();
 
         window.addEvent('domready', function() {
             var path = new URI().getData('path');
diff --git a/src/webui/www/private/shareratio.html b/src/webui/www/private/shareratio.html
index bc56f7974..940804727 100644
--- a/src/webui/www/private/shareratio.html
+++ b/src/webui/www/private/shareratio.html
@@ -14,16 +14,23 @@
         var UseGlobalLimit = -2;
         var NoLimit = -1;
 
-        var keyboardEvents = new Keyboard({
+        new Keyboard({
             defaultEventType: 'keydown',
             events: {
                 'enter': function(event) {
                     $('save').click();
                     event.preventDefault();
+                },
+                'Escape': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                },
+                'Esc': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
                 }
             }
-        });
-        keyboardEvents.activate();
+        }).activate();
 
         window.addEvent('domready', function() {
             var hashesList = new URI().getData('hashes').split('|');
diff --git a/src/webui/www/private/uploadlimit.html b/src/webui/www/private/uploadlimit.html
index 50eb2bf1e..dbba8539a 100644
--- a/src/webui/www/private/uploadlimit.html
+++ b/src/webui/www/private/uploadlimit.html
@@ -55,10 +55,30 @@
                 }
             }
         </script>
-        <input type="button" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]" onclick="setUpLimit()" />
+        <input type="button" id="applyButton" value="QBT_TR(Apply)QBT_TR[CONTEXT=HttpServer]" onclick="setUpLimit()" />
     </div>
 
     <script>
+        new Keyboard({
+            defaultEventType: 'keydown',
+            events: {
+                'enter': function(event) {
+                    $('applyButton').click();
+                    event.preventDefault();
+                },
+                'Escape': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                },
+                'Esc': function(event) {
+                    window.parent.closeWindows();
+                    event.preventDefault();
+                }
+            }
+        }).activate();
+
+        $('uplimitUpdatevalue').focus();
+
         MochaUI.addUpLimitSlider(hashes);
     </script>
 

From 2f33ecf37b8bfeef376fd24936d083cfc637ac8b Mon Sep 17 00:00:00 2001
From: Thomas Piccirello <thomas@piccirello.com>
Date: Thu, 10 Jan 2019 15:49:59 -0800
Subject: [PATCH 2/3] Fix bug where input wouldn't always be focused

---
 src/webui/www/private/newcategory.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/webui/www/private/newcategory.html b/src/webui/www/private/newcategory.html
index 7e5c5dae9..f7d9a36bc 100644
--- a/src/webui/www/private/newcategory.html
+++ b/src/webui/www/private/newcategory.html
@@ -35,10 +35,7 @@
             var uriCategoryName = safeTrim(new URI().getData('categoryName'));
             var uriSavePath = safeTrim(new URI().getData('savePath'));
 
-            if (uriAction === "create") {
-                $('categoryName').focus();
-            }
-            else if (uriAction === "edit") {
+            if (uriAction === "edit") {
                 if (!uriCategoryName)
                     return false;
 
@@ -47,6 +44,9 @@
                 $('savePath').set('value', escapeHtml(uriSavePath));
                 $('savePath').focus();
             }
+            else {
+                $('categoryName').focus();
+            }
 
             $('categoryNameButton').addEvent('click', function(e) {
                 new Event(e).stop();

From 851c02acb0899a4066431679fcef1ddc7693ddf9 Mon Sep 17 00:00:00 2001
From: Thomas Piccirello <thomas@piccirello.com>
Date: Sun, 13 Jan 2019 22:02:07 -0800
Subject: [PATCH 3/3] Capitalize event name

---
 src/webui/www/private/addtrackers.html         | 2 +-
 src/webui/www/private/downloadlimit.html       | 2 +-
 src/webui/www/private/edittracker.html         | 2 +-
 src/webui/www/private/installsearchplugin.html | 2 +-
 src/webui/www/private/newcategory.html         | 2 +-
 src/webui/www/private/rename.html              | 2 +-
 src/webui/www/private/search.html              | 2 +-
 src/webui/www/private/setlocation.html         | 2 +-
 src/webui/www/private/shareratio.html          | 2 +-
 src/webui/www/private/uploadlimit.html         | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/webui/www/private/addtrackers.html b/src/webui/www/private/addtrackers.html
index 5b78735a6..06043ce78 100644
--- a/src/webui/www/private/addtrackers.html
+++ b/src/webui/www/private/addtrackers.html
@@ -14,7 +14,7 @@
             new Keyboard({
                 defaultEventType: 'keydown',
                 events: {
-                    'enter': function(event) {
+                    'Enter': function(event) {
                         $('addTrackersButton').click();
                         event.preventDefault();
                     },
diff --git a/src/webui/www/private/downloadlimit.html b/src/webui/www/private/downloadlimit.html
index 08ae92e3f..66b03715f 100644
--- a/src/webui/www/private/downloadlimit.html
+++ b/src/webui/www/private/downloadlimit.html
@@ -62,7 +62,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(event) {
+                'Enter': function(event) {
                     $('applyButton').click();
                     event.preventDefault();
                 },
diff --git a/src/webui/www/private/edittracker.html b/src/webui/www/private/edittracker.html
index d5162ec80..62c1fc92a 100644
--- a/src/webui/www/private/edittracker.html
+++ b/src/webui/www/private/edittracker.html
@@ -14,7 +14,7 @@
             new Keyboard({
                 defaultEventType: 'keydown',
                 events: {
-                    'enter': function(event) {
+                    'Enter': function(event) {
                         $('editTrackerButton').click();
                         event.preventDefault();
                     },
diff --git a/src/webui/www/private/installsearchplugin.html b/src/webui/www/private/installsearchplugin.html
index 61067d245..c2391bab3 100644
--- a/src/webui/www/private/installsearchplugin.html
+++ b/src/webui/www/private/installsearchplugin.html
@@ -33,7 +33,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(e) {
+                'Enter': function(e) {
                     // accept enter key as a click
                     new Event(e).stop();
 
diff --git a/src/webui/www/private/newcategory.html b/src/webui/www/private/newcategory.html
index f7d9a36bc..1cca0210b 100644
--- a/src/webui/www/private/newcategory.html
+++ b/src/webui/www/private/newcategory.html
@@ -14,7 +14,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(event) {
+                'Enter': function(event) {
                     $('categoryNameButton').click();
                     event.preventDefault();
                 },
diff --git a/src/webui/www/private/rename.html b/src/webui/www/private/rename.html
index 64b2df68b..105597359 100644
--- a/src/webui/www/private/rename.html
+++ b/src/webui/www/private/rename.html
@@ -14,7 +14,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(event) {
+                'Enter': function(event) {
                     $('renameButton').click();
                     event.preventDefault();
                 },
diff --git a/src/webui/www/private/search.html b/src/webui/www/private/search.html
index 62bf59c01..9d1fbc37c 100644
--- a/src/webui/www/private/search.html
+++ b/src/webui/www/private/search.html
@@ -202,7 +202,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(e) {
+                'Enter': function(e) {
                     // accept enter key as a click
                     new Event(e).stop();
 
diff --git a/src/webui/www/private/setlocation.html b/src/webui/www/private/setlocation.html
index c819ff85b..df023dc53 100644
--- a/src/webui/www/private/setlocation.html
+++ b/src/webui/www/private/setlocation.html
@@ -14,7 +14,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(event) {
+                'Enter': function(event) {
                     $('setLocationButton').click();
                     event.preventDefault();
                 },
diff --git a/src/webui/www/private/shareratio.html b/src/webui/www/private/shareratio.html
index 940804727..a05612058 100644
--- a/src/webui/www/private/shareratio.html
+++ b/src/webui/www/private/shareratio.html
@@ -17,7 +17,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(event) {
+                'Enter': function(event) {
                     $('save').click();
                     event.preventDefault();
                 },
diff --git a/src/webui/www/private/uploadlimit.html b/src/webui/www/private/uploadlimit.html
index dbba8539a..4a29d33fc 100644
--- a/src/webui/www/private/uploadlimit.html
+++ b/src/webui/www/private/uploadlimit.html
@@ -62,7 +62,7 @@
         new Keyboard({
             defaultEventType: 'keydown',
             events: {
-                'enter': function(event) {
+                'Enter': function(event) {
                     $('applyButton').click();
                     event.preventDefault();
                 },