From adde3c3f652d22c77d5cd88e80bd72b84626d464 Mon Sep 17 00:00:00 2001
From: Chocobo1 <Chocobo1@users.noreply.github.com>
Date: Mon, 15 Jul 2024 17:03:21 +0800
Subject: [PATCH] WebUI: check headings to have textual content

---
 src/webui/www/.htmlvalidate.json       | 1 -
 src/webui/www/private/views/about.html | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/webui/www/.htmlvalidate.json b/src/webui/www/.htmlvalidate.json
index e923fc76d..347314165 100644
--- a/src/webui/www/.htmlvalidate.json
+++ b/src/webui/www/.htmlvalidate.json
@@ -3,7 +3,6 @@
     "html-validate:recommended"
   ],
   "rules": {
-    "empty-heading": "off",
     "long-title": "off",
     "no-conditional-comment": "off",
     "no-inline-style": "off",
diff --git a/src/webui/www/private/views/about.html b/src/webui/www/private/views/about.html
index 9d6f7151d..3c366501d 100644
--- a/src/webui/www/private/views/about.html
+++ b/src/webui/www/private/views/about.html
@@ -2,7 +2,7 @@
     <img src="images/mascot.png" style="float: left;" alt="QBT_TR(qBittorrent Mascot)QBT_TR[CONTEXT=AboutDialog]" />
     <div>
         <img src="images/qbittorrent-tray.svg" style="float: left; height: 1.5em;" alt="QBT_TR(qBittorrent icon)QBT_TR[CONTEXT=AboutDialog]" />
-        <h3 id="qbittorrentVersion"></h3>
+        <h3 id="qbittorrentVersion">qBittorrent</h3>
     </div>
     <p>QBT_TR(An advanced BitTorrent client programmed in C++, based on Qt toolkit and libtorrent-rasterbar.)QBT_TR[CONTEXT=AboutDialog]</p>
     <p>Copyright © 2006-2024 The qBittorrent project</p>
@@ -855,7 +855,7 @@
         const qbtVersion = window.parent.qBittorrent.Cache.qbtVersion.get();
         const buildInfo = window.parent.qBittorrent.Cache.buildInfo.get();
 
-        $("qbittorrentVersion").innerText = `qBittorrent ${qbtVersion} QBT_TR(WebUI)QBT_TR[CONTEXT=OptionsDialog]`;
+        $("qbittorrentVersion").textContent = `qBittorrent ${qbtVersion} QBT_TR(WebUI)QBT_TR[CONTEXT=OptionsDialog]`;
         $("qtVersion").textContent = buildInfo.qt;
         $("libtorrentVersion").textContent = buildInfo.libtorrent;
         $("boostVersion").textContent = buildInfo.boost;